docs(sidenav) property binding #9330
Conversation
googlebot
added
the
cla: yes
| @@ -1,5 +1,5 @@ | |||
| <mat-sidenav-container class="example-container" *ngIf="shouldRun"> | |||
| <mat-sidenav mode="side" opened="true">Sidenav content</mat-sidenav> | |||
| <mat-sidenav mode="side" [opened]="true">Sidenav content</mat-sidenav> | |||
There was a problem hiding this comment.
This can actually just be opened with no assignment
<mat-sidenav mode="side" opened>There was a problem hiding this comment.
Yeah, you're right!
But maybe it should be more verbose for the sake of clarity? Brief search showed that it is common for the docs to have [bSome]="true" rather than just bSome.
There was a problem hiding this comment.
In general I prefer to use the short form, otherwise people will interpret the examples as needing to be written out the long way.
There was a problem hiding this comment.
Can I interpret that as a suggestion to fix every example in the docs according to your preferences?
There was a problem hiding this comment.
If you want to correct other examples feel free to send additional PRs.
|
@debudda do you want to make the change above to merge this PR? |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Should be a property binding according to docs.