refactor(typography): add mixin for shorthand declaration and use shorthand for h5 and h6 #9346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
donroyco
reviewed
Jan 12, 2018
| // in order to prevent SASS from dividing the two values. | ||
| // Otherwise use the shorthand `font`, because it's the least amount of bytes. Note | ||
| // that we need to use interpolation for `font-size/line-height` in order to prevent | ||
| // SASS from dividing the two values. |
crisbeto
force-pushed
the
typography-shorthands-mixin
branch
from
30595c3 to
811bae2
Compare
|
needs rebase |
josephperrott
added
pr: needs rebase
and removed
action: merge
…rthand for h5 and h6 * Moves our `font` declaration shorthand logic into the `mat-typography-font-shorthand` mixin to make it easier to use without passing in a typography config. * Switches the `h5` and `h6` to use the shorthands.
crisbeto
force-pushed
the
typography-shorthands-mixin
branch
from
811bae2 to
de81726
Compare
crisbeto
added
action: merge
|
Rebased. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fontdeclaration shorthand logic into themat-typography-font-shorthandmixin to make it easier to use without passing in a typography config.h5andh6to use the shorthands.