Skip to content

chore: reorganize cdk/a11y directory structure #9389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 14, 2018

  • Since the @angular/cdk/a11y has grown a lot, it's becoming harder to navigate. These changes distribute the files into directories similarly to how we do it in overlay.
  • Removes the individual imports from the focus trap tests in favor of importing the A11yModule.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 14, 2018
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 14, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 16, 2018
@josephperrott
Copy link
Member

needs rebase

@josephperrott josephperrott added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Jan 19, 2018
@crisbeto crisbeto force-pushed the cdk-a11y-reorganize branch from d2216a6 to d2bbd86 Compare January 19, 2018 20:07
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Jan 19, 2018
@crisbeto
Copy link
Member Author

Rebased.

@jelbourn
Copy link
Member

@crisbeto Passes google presubmit, can merge as soon as it's rebased... again (sorry)

@crisbeto crisbeto force-pushed the cdk-a11y-reorganize branch from d2bbd86 to 3f65af3 Compare January 23, 2018 18:09
@crisbeto
Copy link
Member Author

Rebased,

@jelbourn
Copy link
Member

Looks like there's a build error now

@crisbeto crisbeto force-pushed the cdk-a11y-reorganize branch from 3f65af3 to 65b1744 Compare January 24, 2018 17:58
@crisbeto
Copy link
Member Author

Rebased and fixed a couple of wrong imports.

* Since the `@angular/cdk/a11y` has grown a lot, it's becoming harder to navigate. These changes distribute the files into directories similarly to how we do it in `overlay`.
* Removes individual imports from the focus trap tests in favor of importing the `A11yModule`.
@crisbeto crisbeto force-pushed the cdk-a11y-reorganize branch from 65b1744 to 17d0c2e Compare January 25, 2018 15:44
@jelbourn jelbourn merged commit ff0e612 into angular:master Jan 25, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants