Skip to content

build: escape html tags and close unclosed backticks #9583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2018
Merged

build: escape html tags and close unclosed backticks #9583

merged 2 commits into from
Jan 25, 2018

Conversation

julianobrasil
Copy link
Contributor

Should be merged before #8200 (see #8200 (comment))

cc: @jelbourn

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 24, 2018
@jelbourn
Copy link
Member

@julianobrasil just some lint errors from lines going over 100 columns

@julianobrasil
Copy link
Contributor Author

done.

@jelbourn
Copy link
Member

@julianobrasil could you rebase this? The files in cdk/a11y just moved to a new location. I should be able to merge it right after

@julianobrasil
Copy link
Contributor Author

@jelbourn, I've finished the rebasing.

jelbourn
jelbourn approved these changes Jan 25, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 25, 2018
@jelbourn jelbourn merged commit 40a5070 into angular:master Jan 25, 2018
@jelbourn jelbourn mentioned this pull request Jan 25, 2018
Closed
@julianobrasil julianobrasil mentioned this pull request Jan 26, 2018
Merged
@julianobrasil julianobrasil deleted the fixUnescapedHtml branch January 26, 2018 00:51
@jelbourn jelbourn added target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels Jan 29, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@crisbeto crisbeto Awaiting requested review from crisbeto

@devversion devversion Awaiting requested review from devversion

@josephperrott josephperrott Awaiting requested review from josephperrott

@kara kara Awaiting requested review from kara

@mmalerba mmalerba Awaiting requested review from mmalerba

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianobrasil @jelbourn @googlebot