Skip to content

docs(tree): add tree examples #9585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2018
Merged

docs(tree): add tree examples #9585

merged 1 commit into from
Feb 16, 2018

Conversation

tinayuangao
Copy link
Contributor

Add two tree overview example

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 25, 2018
jelbourn
jelbourn reviewed Jan 25, 2018
View reviewed changes
src/material-examples/tree-flat-overview/tree-flat-overview-example.css Outdated
@@ -0,0 +1,9 @@
.tree-demo-invisible {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefix with example-

(here and elsewhere)

src/material-examples/tree-flat-overview/tree-flat-overview-example.css Outdated
display: none;
}

ul, li {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be gated by some css class

src/material-examples/tree-flat-overview/tree-flat-overview-example.ts Outdated
import {of} from 'rxjs/observable/of';
import {BehaviorSubject} from 'rxjs/BehaviorSubject';

export class JsonNode {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add description?

src/material-examples/tree-flat-overview/tree-flat-overview-example.ts Outdated
}

/** Flat node with expandable and level information */
export class JsonFlatNode {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to make these more clearly examples specific to some use-case

src/material-examples/tree-flat-overview/tree-flat-overview-example.ts Outdated
}}`;

@Injectable()
export class JsonDatabase {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use more comments in general to explain what's going on

amcdnl
amcdnl reviewed Jan 26, 2018
View reviewed changes
src/material-examples/tree-nested-overview/tree-nested-overview-example.css Outdated
}

ul, li {
-webkit-margin-before: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might add a comment about this.

amcdnl
amcdnl reviewed Jan 26, 2018
View reviewed changes
src/material-examples/tree-nested-overview/tree-nested-overview-example.html Outdated
</button>
{{node.key}}
</div>
<ul [class]="nestedTreeControl.isExpanded(node) ? '' : 'tree-demo-invisible'">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be better as ngClass:

[ngClass]="{ 'tree-demo-invisible': nestedTreeControl.isExpanded(node) }"

amcdnl
amcdnl reviewed Jan 26, 2018
View reviewed changes
src/material-examples/tree-nested-overview/tree-nested-overview-example.ts Outdated
this.nestedTreeControl = new NestedTreeControl<JsonNode>(this._getChildren);
this.nestedDataSource = new MatTreeNestedDataSource();

database.dataChange.subscribe(data => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could omit {}

@tinayuangao tinayuangao force-pushed the tree-example branch 3 times, most recently from bfff5f0 to beb641a Compare February 7, 2018 23:56
@tinayuangao
Copy link
Contributor Author

Comments addressed. Thanks for review!

jelbourn
jelbourn reviewed Feb 9, 2018
View reviewed changes
src/material-examples/tsconfig-build.json Outdated
@@ -24,8 +24,10 @@
"paths": {
"@angular/material/*": ["../../dist/packages/material/*"],
"@angular/material": ["../../dist/packages/material/public-api"],
"@angular/material-experimental/*": ["../../dist/packages/material-experimental/*"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should actually just move the tree into src/lib now that we're on for next major

@tinayuangao
Copy link
Contributor Author

Comments addressed. Please take a look. Thanks!

jelbourn
jelbourn approved these changes Feb 15, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Feb 15, 2018
@tinayuangao tinayuangao merged commit 631397c into angular:tree Feb 16, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amcdnl amcdnl amcdnl left review comments

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tinayuangao @amcdnl @jelbourn @googlebot