Skip to content

build: auto generate example module #9590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

devversion
Copy link
Member

  • No longer pushes the example-module.ts file to the GitHub repository. The file will be auto-generated once the material-examples build package is being built.

References #9574.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 25, 2018
* No longer pushes the example-module.ts file to the GitHub repository. The file will be auto-generated once the `material-examples` build package is being built.

References angular#9574.
@devversion devversion force-pushed the build/auto-build-example-module branch from a32bca9 to 6443d13 Compare January 25, 2018 13:55
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 25, 2018
@jelbourn jelbourn merged commit e7af740 into angular:master Jan 25, 2018
@devversion devversion deleted the build/auto-build-example-module branch January 25, 2018 20:42
Copy link
Contributor

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels Jan 29, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants