chore: fix warning about unconfigurable property #9599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
devversion
force-pushed
the
chore/fix-warning-unconfiguraböle-property
branch
from
3ceab89 to
30aa9d6
Compare
Fixes that some browsers in Browserstack or Saucelabs warn about the `defineProperty` call in the interactivity checker tests.
`LOG: 'Attempting to configure 'frameElement' with descriptor '{}' on object '[object Window]' and got error, giving up: TypeError: Attempting to change the getter of an unconfigurable property.'`.
This happens because some browsers explicitly set all properties to `configurable: false` on `window` objects. Since this is only happening inside of Safari, we don't overwrite the property.
devversion
force-pushed
the
chore/fix-warning-unconfiguraböle-property
branch
from
30aa9d6 to
4573b49
Compare
jelbourn
added
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that some browsers in Browserstack or Saucelabs warn about the
definePropertycall in the interactivity checker tests.LOG: 'Attempting to configure 'frameElement' with descriptor '{}' on object '[object Window]' and got error, giving up: TypeError: Attempting to change the getter of an unconfigurable property.'.This happens because some browsers explicitly set all properties to
configurable: falseonwindowobjects. To avoid such warnings, we can just check if the properties is configurable (or doesn't exist).