refactor(select,autocomplete): consolidate logic for scrolling options into view #9630
Conversation
googlebot
added
the
cla: yes
src/lib/core/option/option.ts
Outdated
| * @param currentScrollPosition Current scroll position of the panel. | ||
| * @param panelHeight Height of the panel. | ||
| */ | ||
| static getScrollPosition(optionIndex: number, optionHeight: number, currentScrollPosition: number, |
There was a problem hiding this comment.
Could this be a standalone function rather than living on MatOption? Should this also be internal?
There was a problem hiding this comment.
I went for consistency since the countGroupLabelsBeforeOption is also a static method. I'm fine with making it internal, but I can see it being useful if somebody is implementing a component that uses MatOption.
There was a problem hiding this comment.
I'd rather keep the public API smaller and see if it comes up as a request first
…s into view Combines some duplicated logic for determining how to scroll an option into view into a single place so it's easier to maintain.
crisbeto
force-pushed
the
select-autocomplete-scroll-logic
branch
from
739ef05 to
aab7426
Compare
jelbourn
added
pr: lgtm
action: merge
…s into view (#9630) Combines some duplicated logic for determining how to scroll an option into view into a single place so it's easier to maintain.
…s into view (#9630) Combines some duplicated logic for determining how to scroll an option into view into a single place so it's easier to maintain.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Combines some duplicated logic for determining how to scroll an option into view into a single place so it's easier to maintain.