Skip to content

fix(block-scroll-strategy): server-side rendering error #9665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2018
Merged

fix(block-scroll-strategy): server-side rendering error #9665

merged 1 commit into from
Feb 1, 2018

Conversation

crisbeto
Copy link
Member

Fixes a server-side rendering error in the BlockScrollStrategy, because it was referring to the global document.

Relates to #9066.

@crisbeto
fix(block-scroll-strategy): server-side rendering error
32d246d 
Fixes a server-side rendering error in the `BlockScrollStrategy`, because it was referring to the global `document`.

Relates to angular#9066.
@crisbeto crisbeto requested a review from jelbourn as a code owner January 29, 2018 18:08
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 29, 2018
@crisbeto crisbeto mentioned this pull request Jan 29, 2018
Closed
jelbourn
jelbourn approved these changes Jan 30, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Jan 30, 2018
@tinayuangao tinayuangao merged commit 3acbf26 into angular:master Feb 1, 2018
mmalerba pushed a commit to mmalerba/components that referenced this pull request Feb 1, 2018
@crisbeto @mmalerba
fix(block-scroll-strategy): server-side rendering error (angular#9665)
21c603c 
Fixes a server-side rendering error in the `BlockScrollStrategy`, because it was referring to the global `document`.

Relates to angular#9066.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @tinayuangao