fix(tabs): hide mat-tab-nav-bar ink bar when no link is active #9701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Fixes #4436 |
jelbourn
approved these changes
Apr 9, 2018
| /** Notifies the component that the active link has been changed. */ | ||
| /** | ||
| * Notifies the component that the active link has been changed. | ||
| * @deletion-target 6.0.0 `element` parameter to be removed. |
jelbourn
added
pr: lgtm
action: merge
Currently the `mat-tab-nav-bar` updates the ink bar location whenever a link becomes active, however this doesn't account for the case where none of the links are active. These changes switch to checking for active links whenever the active state of any of the tabs changes and hiding the ink bar if none of them are active. Fixes angular#9671.
crisbeto
force-pushed
the
9671/tab-nav-bar-no-active-link
branch
from
0bce0f8 to
eac10e2
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 20, 2018
…rotected properties In angular#9701 we made the `_activeLinkChanged` and `_activeLinkElement` properties private which makes them inaccessible when extending. These changes switch them to be protected. Fixes angular#10939.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
mat-tab-nav-barupdates the ink bar location whenever a link becomes active, however this doesn't account for the case where none of the links are active. These changes switch to checking for active links whenever the active state of any of the tabs changes and hiding the ink bar if none of them are active.Fixes #9671.