Skip to content

update(radio, slide-toggle, checkbox): faster ripple enter animations #9754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

devversion
Copy link
Member

  • Updates the slide-toggle, radio and checkbox ripples to have a quicker enter animation. This aligns more with the behavior MDC provides, and also feels more appropriate (for focus indicators) and is also more aligned with the specs.

* Updates the slide-toggle, radio and checkbox ripples to have a quicker enter animation. This aligns more with the behavior MDC provides, and also feels more appropriate (for focus indicators) and is also more aligned with the specs.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 2, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 2, 2018
@devversion devversion added the target: patch This PR is targeted for the next patch release label Feb 6, 2018
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit e4dd5d7 into angular:master Feb 8, 2018
@devversion devversion deleted the update/faster-ripple-animation branch February 8, 2018 21:48
mmalerba pushed a commit that referenced this pull request Feb 8, 2018
…#9754)

* Updates the slide-toggle, radio and checkbox ripples to have a quicker enter animation. This aligns more with the behavior MDC provides, and also feels more appropriate (for focus indicators) and is also more aligned with the specs.
tinayuangao pushed a commit that referenced this pull request Feb 9, 2018
…#9754)

* Updates the slide-toggle, radio and checkbox ripples to have a quicker enter animation. This aligns more with the behavior MDC provides, and also feels more appropriate (for focus indicators) and is also more aligned with the specs.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants