Skip to content

build: add tslint rule to enforce deletion targets #9881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

crisbeto
Copy link
Member

Adds a tslint rule that will mark any deletion targets that are due to be deleted.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 10, 2018
Adds a tslint rule that will mark any deletion targets that are due to be deleted.
@crisbeto crisbeto force-pushed the deletion-target-rule branch from 0f4521b to 5db7a07 Compare February 10, 2018 12:57
CaerusKaru added a commit to angular/flex-layout that referenced this pull request Feb 12, 2018
CaerusKaru added a commit to angular/flex-layout that referenced this pull request Feb 12, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It would also be cool to ensure that anything @deprecated has a deletion target

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 13, 2018
ThomasBurleson pushed a commit to angular/flex-layout that referenced this pull request Feb 13, 2018
@jelbourn jelbourn merged commit b6e7174 into angular:master Feb 13, 2018
crisbeto added a commit to crisbeto/material2 that referenced this pull request Feb 13, 2018
Follow-up from angular#9881. Ensures that anything marked with `@deprecated` also has a `@deletion-target`.
jelbourn pushed a commit that referenced this pull request Feb 13, 2018
Follow-up from #9881. Ensures that anything marked with `@deprecated` also has a `@deletion-target`.
andrewseguin pushed a commit that referenced this pull request Feb 20, 2018
Adds a tslint rule that will mark any deletion targets that are due to be deleted.
andrewseguin pushed a commit that referenced this pull request Feb 20, 2018
Follow-up from #9881. Ensures that anything marked with `@deprecated` also has a `@deletion-target`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants