Skip to content

chore: fix e2e axe failure #9929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2018
Merged

chore: fix e2e axe failure #9929

merged 1 commit into from
Feb 20, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 13, 2018 •
edited
Loading

Fixes the e2e setup failing due to an error being thrown by the Axe plugin that was caused by us having two main landmarks.

@crisbeto crisbeto added the in progress This issue is currently in progress label Feb 13, 2018
@crisbeto crisbeto self-assigned this Feb 13, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner February 13, 2018 17:36
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 13, 2018
@crisbeto crisbeto assigned jelbourn and unassigned crisbeto Feb 13, 2018
@crisbeto crisbeto added pr: needs review and removed in progress This issue is currently in progress labels Feb 13, 2018
jelbourn
jelbourn approved these changes Feb 13, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm glad this failed because until now I thought it wasn't even running any more

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 13, 2018
@jelbourn jelbourn merged commit 2abdb65 into angular:master Feb 20, 2018
tinayuangao pushed a commit that referenced this pull request Feb 20, 2018
@crisbeto @tinayuangao
chore: fix e2e axe failure (#9929)
a259e4c
andrewseguin pushed a commit that referenced this pull request Feb 20, 2018
@crisbeto @andrewseguin
chore: fix e2e axe failure (#9929)
be628a3
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @googlebot