Skip to content

fix(badge): remove top-level ampersand selectors from theme mixin #9991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2018
Merged

fix(badge): remove top-level ampersand selectors from theme mixin #9991

merged 1 commit into from
Feb 18, 2018

Conversation

crisbeto
Copy link
Member

Fixes the badge theme not compiling in some cases, because it contains a couple of top-level ampersand selectors.

Fixes #9990.

@crisbeto
fix(badge): remove top-level ampersand selectors from theme mixin
bcc1a70 
Fixes the badge theme not compiling in some cases, because it contains a couple of top-level ampersand selectors.

Fixes angular#9990.
@crisbeto crisbeto requested a review from amcdnl as a code owner February 16, 2018 21:59
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 16, 2018
jelbourn
jelbourn approved these changes Feb 17, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 17, 2018
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 17, 2018
amcdnl
amcdnl approved these changes Feb 17, 2018
View reviewed changes
Copy link
Contributor

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit bd7a408 into angular:master Feb 18, 2018
@tcober
Copy link

tcober commented Feb 18, 2018

Thanks so much!!

tinayuangao pushed a commit that referenced this pull request Feb 20, 2018
@crisbeto @tinayuangao
fix(badge): remove top-level ampersand selectors from theme mixin (#9991
ebe794d 
)

Fixes the badge theme not compiling in some cases, because it contains a couple of top-level ampersand selectors.

Fixes #9990.
@andrewseguin andrewseguin added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Feb 20, 2018
crisbeto added a commit to crisbeto/material2 that referenced this pull request Mar 6, 2018
@crisbeto
build: add stylelint rule to avoid top-level ampersands in themes
2994528 
* Adds a stylelint rule that will log a warning for top-level ampersand selectors inside of mixins. This will help us avoid issues like angular#9991 in the future.
* Makes the `mat-radio-color` internal.
@crisbeto crisbeto mentioned this pull request Mar 6, 2018
Merged
jelbourn pushed a commit that referenced this pull request Mar 6, 2018
@crisbeto @jelbourn
build: add stylelint rule to avoid top-level ampersands in themes (#1…
7ff086a 
…0280)

* Adds a stylelint rule that will log a warning for top-level ampersand selectors inside of mixins. This will help us avoid issues like #9991 in the future.
* Makes the `mat-radio-color` internal.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amcdnl amcdnl amcdnl approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't compile sass because of mat-badge-theme mixin error
6 participants
@crisbeto @tcober @amcdnl @jelbourn @googlebot @andrewseguin