fix(lock-closed): update policyUrl in bundle.js
#80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #77, `policyUrl` was fixed in `src/main.ts`, but not in the built file that is actually used when running the action (`lib/bundle.js`). As a result, the change did not take effect. This commit updates `policyUrl` to `lib/bundle.js` as well. This will help address angular/angular#39358 (once [lock-closed.yml][1] is updated in all affected repositories). [1]: https://github.com/angular/angular/blob/cfac8e0764498713f63a2335b46823e8a9b285c5/.github/workflows/lock-closed.yml#L13
Change the `main` field in `package.json` to point to the correct file, i.e. `lib/bundle.js` instead of `lib/main.js`. This doesn't have any practical effect, since [action.yml][1] specifies the actual entry-point used for the action, but it avoids confusion. [1]: https://github.com/angular/dev-infra/blob/414834b2b24dd2df37c6ed00808387ee6fd91b66/github-actions/lock-closed/action.yml#L13
…lock-bot-token) In PR #40, the authentication used by the `lock-closed` action was changed. As part of this change, the `github-token` input parameter was replaced by `lock-bot-token`. However, `lock-closed/action.yml` was not updated accordingly, resulting in the following warning ([example][1]): > Unexpected input(s) 'lock-bot-key', valid inputs are > ['github-token', 'locks-per-execution'] This commit gets rid of the warnings by updating `action.yml` to list the correct inputs. [1]: https://github.com/angular/angular/actions/runs/318094899
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Oct 21, 2020
This commit updates the version of the `dev-infra/lock-closed` GitHub action to the latest version, that includes the fix from angular/dev-infra#80.
gkalpak
added a commit
to gkalpak/angular-cli
that referenced
this pull request
Oct 21, 2020
This commit updates the version of the `dev-infra/lock-closed` GitHub action to the latest version, that includes the fix from angular/dev-infra#80.
gkalpak
added a commit
to gkalpak/components
that referenced
this pull request
Oct 21, 2020
This commit updates the version of the `dev-infra/lock-closed` GitHub action to the latest version, that includes the fix from angular/dev-infra#80.
gkalpak
added a commit
to gkalpak/universal
that referenced
this pull request
Oct 21, 2020
This commit updates the version of the `dev-infra/lock-closed` GitHub action to the latest version, that includes the fix from angular/dev-infra#80.
This was referenced Oct 21, 2020
alan-agius4
pushed a commit
to angular/universal
that referenced
this pull request
Oct 21, 2020
This commit updates the version of the `dev-infra/lock-closed` GitHub action to the latest version, that includes the fix from angular/dev-infra#80.
alan-agius4
pushed a commit
to angular/angular-cli
that referenced
this pull request
Oct 21, 2020
This commit updates the version of the `dev-infra/lock-closed` GitHub action to the latest version, that includes the fix from angular/dev-infra#80.
alxhub
pushed a commit
to angular/angular
that referenced
this pull request
Oct 22, 2020
This commit updates the version of the `dev-infra/lock-closed` GitHub action to the latest version, that includes the fix from angular/dev-infra#80. PR Close #39371
alxhub
pushed a commit
to angular/angular
that referenced
this pull request
Oct 22, 2020
This commit updates the version of the `dev-infra/lock-closed` GitHub action to the latest version, that includes the fix from angular/dev-infra#80. PR Close #39371
wagnermaciel
pushed a commit
to angular/components
that referenced
this pull request
Oct 26, 2020
This commit updates the version of the `dev-infra/lock-closed` GitHub action to the latest version, that includes the fix from angular/dev-infra#80.
wagnermaciel
pushed a commit
to angular/components
that referenced
this pull request
Oct 26, 2020
This commit updates the version of the `dev-infra/lock-closed` GitHub action to the latest version, that includes the fix from angular/dev-infra#80. (cherry picked from commit 6760574)
wagnermaciel
pushed a commit
to angular/components
that referenced
this pull request
Oct 26, 2020
This commit updates the version of the `dev-infra/lock-closed` GitHub action to the latest version, that includes the fix from angular/dev-infra#80. (cherry picked from commit 6760574)
trik
pushed a commit
to gnucoop/gngt
that referenced
this pull request
Nov 9, 2020
This commit updates the version of the `dev-infra/lock-closed` GitHub action to the latest version, that includes the fix from angular/dev-infra#80.
trik
pushed a commit
to gnucoop/gngt
that referenced
this pull request
Nov 9, 2020
This commit updates the version of the `dev-infra/lock-closed` GitHub action to the latest version, that includes the fix from angular/dev-infra#80.
CaerusKaru
added a commit
to angular/flex-layout
that referenced
this pull request
Nov 12, 2020
This commit updates the version of the `dev-infra/lock-closed` GitHub action to the latest version, that includes the fix from angular/dev-infra#80.
CaerusKaru
added a commit
to angular/flex-layout
that referenced
this pull request
Nov 12, 2020
This commit updates the version of the `dev-infra/lock-closed` GitHub action to the latest version, that includes the fix from angular/dev-infra#80.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes three fixes. See the individual commits for more details:
policyUrlinbundle.jsmainfield inpackage.jsoninputsinaction.yml(github-token --> lock-bot-token)(This PR will help address angular/angular#39358.)