fix(circleci-orb): support empty input parameters when e.g. running in cronjob #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 23, 2022
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 23, 2022
devversion
added a commit
to angular/components
that referenced
this pull request
Sep 23, 2022
Contains: angular/dev-infra#838 (cherry picked from commit e71a1ba)
devversion
added a commit
to angular/components
that referenced
this pull request
Sep 23, 2022
…n cronjob CircleCI cronjobs do not have the base revision or revision pipeline variables, so they may be empty. To avoid using empty variables which would then cause errors in our shared command- we support the empty string fallback. The command will be a noop anyway since we check for these variables in the actual script. See: https://app.circleci.com/pipelines/github/angular/components/44462.
devversion
force-pushed
the
fix-rebase-orb-action
branch
from
b5b0159 to
8cb3011
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircleCI cronjobs do not have the base revision or revision pipeline variables, so they may be empty. To avoid using empty variables which would then cause errors in our shared command- we support the empty string fallback. The command will be a noop anyway since we check for these variables in the actual script.
See: https://app.circleci.com/pipelines/github/angular/components/44462.