Skip to content
This repository was archived by the owner on Mar 31, 2025. It is now read-only.

Commit ed27563

Browse files
roddolfpetebacondarwin
authored andcommitted
fix(git): use correct shell execution status property
The previous migration from `shelljs` to `child_process` in commit 18a1c0b failed to update some usage of the return status properties from `.code` to `.status`.
1 parent 49b431f commit ed27563

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

git/mocks/mocks.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,39 +26,39 @@ var mockVersionInfo = {
2626
};
2727

2828
var mockGitLsRemoteTags = {
29-
code: 0,
29+
status: 0,
3030
stdout: '85ae09c2119bf9b20cd45fc4e9dab77c5940d627 refs/tags/v0.10.11-rc2\n' +
3131
'373c3bf61785139a65e76c023e798b49b7437c37 refs/tags/v0.10.13\n' +
3232
'573c3bf61795139a65e76c023e798b49b7437c37 refs/tags/v1.3.invalid'
3333
};
3434

3535
var mockGitRevParse = {
36-
code: 0,
36+
status: 0,
3737
stdout: 'revision'
3838
}
3939

4040
var mockGitCatFile = {
41-
code: 0,
41+
status: 0,
4242
stdout: 'codename(mockCodeName)'
4343
}
4444

4545
var mockGitCatFileNoCodeName = {
46-
code: 0,
46+
status: 0,
4747
stdout: 'no code name'
4848
}
4949

5050
var mockGitCatFileBadFormat = {
51-
code: 0,
51+
status: 0,
5252
stdout: 'bad format codename()'
5353
}
5454

5555
var mockGitDescribe = {
56-
code: 0,
56+
status: 0,
5757
stdout: 'v0.10.15'
5858
};
5959

6060
var mockDefaultFail = {
61-
code: 1,
61+
status: 1,
6262
stdout: "default"
6363
};
6464

git/services/versionInfo.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ function getBuild() {
5858
var getTaggedVersion = function() {
5959
var gitTagResult = child.spawnSync('git', ['describe', '--exact-match'], {encoding:'utf8'});
6060

61-
if (gitTagResult.code === 0) {
61+
if (gitTagResult.status === 0) {
6262
var tag = gitTagResult.stdout.trim();
6363
var version = semver.parse(tag);
6464

test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ require('source-map-support').install();
1515
const Jasmine = require('jasmine');
1616
const jasmine = new Jasmine({ projectBaseDir: __dirname });
1717
jasmine.loadConfig({ spec_files: ['!(node_modules)/**/*.spec.js'] });
18-
jasmine.execute();
18+
jasmine.execute();

0 commit comments

Comments
 (0)