Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

Commit 63709a9

Browse files
committed
fix: import individual rx operators
* Removes 'rxjs/operators' import in favor of indivial imports, adds lint rule to prevent that type of import * Maintains parity with angular/components#8160
1 parent b01c2d7 commit 63709a9

File tree

10 files changed

+20
-16
lines changed

10 files changed

+20
-16
lines changed

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"@angular/core": "~4.4.4",
3232
"@angular/platform-browser": "~4.4.4",
3333
"core-js": "^2.4.1",
34-
"rxjs": "^5.5.0",
34+
"rxjs": "^5.5.2",
3535
"systemjs": "0.19.43",
3636
"tsickle": "^0.23.5",
3737
"tslib": "^1.8.0",
@@ -125,4 +125,4 @@
125125
"typescript": "~2.4.2",
126126
"uglify-js": "^2.8.14"
127127
}
128-
}
128+
}

src/demo-app/system-config.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ System.config({
4949
packages: {
5050
// 3rd-Party barrels.
5151
'rxjs': { main: 'index' },
52-
'rxjs/operators': {main: 'index'},
5352
// Set the default extension for the root package, because otherwise the demo-app can't
5453
// be built within the production mode. Due to missing file extensions.
5554
'.': {

src/lib/api/core/responsive-activation.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88
import {Subscription} from 'rxjs/Subscription';
9-
import {map} from 'rxjs/operators';
9+
import {map} from 'rxjs/operators/map';
1010

1111
import {MediaChange, MediaQuerySubscriber} from '../../media-query/media-change';
1212
import {BreakPoint} from '../../media-query/breakpoints/break-point';

src/lib/media-query/match-media.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {ɵgetDOM as getDom} from '@angular/platform-browser';
1010
import {DOCUMENT} from '@angular/common';
1111
import {BehaviorSubject} from 'rxjs/BehaviorSubject';
1212
import {Observable} from 'rxjs/Observable';
13-
import {filter} from 'rxjs/operators';
13+
import {filter} from 'rxjs/operators/filter';
1414

1515
import {MediaChange} from './media-change';
1616

src/lib/media-query/media-monitor.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ import {MediaChange} from './media-change';
1515
import {mergeAlias} from '../utils/add-alias';
1616

1717
import {Observable} from 'rxjs/Observable';
18-
import {filter, map} from 'rxjs/operators';
18+
import {filter} from 'rxjs/operators/filter';
19+
import {map} from 'rxjs/operators/map';
1920

2021
/**
2122
* MediaMonitor uses the MatchMedia service to observe mediaQuery changes (both activations and

src/lib/media-query/observable-media.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
*/
88
import {TestBed, inject, async} from '@angular/core/testing';
99

10-
import {filter, map} from 'rxjs/operators';
10+
import {filter} from 'rxjs/operators/filter';
11+
import {map} from 'rxjs/operators/map';
1112

1213
import {BreakPoint} from './breakpoints/break-point';
1314
import {BREAKPOINTS} from './breakpoints/break-points-token';

src/lib/media-query/observable-media.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ import {Injectable} from '@angular/core';
1010
import {Subscription} from 'rxjs/Subscription';
1111
import {Observable, Subscribable} from 'rxjs/Observable';
1212

13-
import {map, filter} from 'rxjs/operators';
13+
import {map} from 'rxjs/operators/map';
14+
import {filter} from 'rxjs/operators/filter';
1415

1516
import {BreakPointRegistry} from './breakpoints/break-point-registry';
1617

tools/package-tools/rollup-globals.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,14 @@ export const rollupGlobals = {
5252
'rxjs/Subscriber': 'Rx',
5353
'rxjs/Scheduler': 'Rx',
5454
'rxjs/ReplaySubject': 'Rx',
55+
5556
'rxjs/observable/combineLatest': 'Rx.Observable',
5657
'rxjs/observable/forkJoin': 'Rx.Observable',
5758
'rxjs/observable/fromEvent': 'Rx.Observable',
5859
'rxjs/observable/merge': 'Rx.Observable',
5960
'rxjs/observable/of': 'Rx.Observable',
6061
'rxjs/observable/throw': 'Rx.Observable',
6162
'rxjs/observable/defer': 'Rx.Observable',
62-
'rxjs/operators': 'Rx.Observable',
63-
'rxjs/operators/index': 'Rx.Observable',
6463

6564
'rxjs/add/observable/merge': 'Rx.Observable',
6665
'rxjs/add/observable/fromEvent': 'Rx.Observable',
@@ -72,5 +71,8 @@ export const rollupGlobals = {
7271
'rxjs/add/operator/distinctUntilChanged': 'Rx.Observable.prototype',
7372
'rxjs/add/operator/first': 'Rx.Observable.prototype',
7473
'rxjs/add/operator/catch': 'Rx.Observable.prototype',
75-
'rxjs/add/operator/switchMap': 'Rx.Observable.prototype'
74+
'rxjs/add/operator/switchMap': 'Rx.Observable.prototype',
75+
76+
'rxjs/operators/filter': 'Rx.Observable',
77+
'rxjs/operators/map': 'Rx.Observable',
7678
};

tslint.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
["xdescribe"]
7676
],
7777
// Disallows importing the whole RxJS library. Submodules can be still imported.
78-
"import-blacklist": [true, "rxjs"],
78+
"import-blacklist": [true, "rxjs", "rxjs/operators"],
7979
// Avoids inconsistent linebreak styles in source files. Forces developers to use LF linebreaks.
8080
"linebreak-style": [true, "LF"],
8181

0 commit comments

Comments
 (0)