Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

Commit 4f031fc

Browse files
committed
fix(header-link): remove title
- the aria-label is sufficient Relates to #671.
1 parent 5ca76d1 commit 4f031fc

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

src/app/shared/doc-viewer/doc-viewer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {ComponentPortal, DomPortalHost, DomPortalOutlet} from '@angular/cdk/portal';
1+
import {ComponentPortal, DomPortalOutlet} from '@angular/cdk/portal';
22
import {HttpClient, HttpErrorResponse} from '@angular/common/http';
33
import {DomSanitizer} from '@angular/platform-browser';
44
import {
@@ -107,7 +107,7 @@ export class DocViewer implements OnDestroy {
107107

108108
Array.prototype.slice.call(exampleElements).forEach((element: Element) => {
109109
const example = element.getAttribute(componentName);
110-
const portalHost = new DomPortalHost(
110+
const portalHost = new DomPortalOutlet(
111111
element, this._componentFactoryResolver, this._appRef, this._injector);
112112
const examplePortal = new ComponentPortal(componentClass, this._viewContainerRef);
113113
const exampleViewer = portalHost.attach(examplePortal);

src/app/shared/doc-viewer/header-link.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,8 @@ import {Router} from '@angular/router';
1717
@Component({
1818
selector: 'header-link',
1919
template: `
20-
<a
21-
title="Link to this heading"
22-
aria-label="Link to this heading"
23-
class="docs-markdown-a"
24-
[attr.aria-describedby]="example"
25-
[href]="_getFragmentUrl()">
20+
<a aria-label="Link to this heading" class="docs-markdown-a"
21+
[attr.aria-describedby]="example" [href]="_getFragmentUrl()">
2622
<mat-icon>link</mat-icon>
2723
</a>
2824
`

yarn.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,8 @@
187187
integrity sha512-kwX6475iuFEWcQc62mgd9Dq1lGMvqZXxEc0EZqsewi9Dpg/rj0ImXeYOTtIKFrgAkg03ahADBjtCComB0eKZgg==
188188

189189
"@angular/components-examples@angular/material2-docs-content#master":
190-
version "9.0.0-rc.5-sha-8796d7cc6"
191-
resolved "https://codeload.github.com/angular/material2-docs-content/tar.gz/3b51f24fa4318f5d649b59f5fa4ade54f16b13d0"
190+
version "9.0.0-rc.6-sha-a30094b47"
191+
resolved "https://codeload.github.com/angular/material2-docs-content/tar.gz/177ef7b8f91e3834e0749bdf48c02a9b870758c3"
192192

193193
"@angular/core@^9.0.0-rc.7":
194194
version "9.0.0-rc.7"

0 commit comments

Comments
 (0)