Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

Commit 94216e3

Browse files
committed
fix: use header and main tags for more semantic HTML
- improves screen reader support - footer tags were already properly used Relates to #671.
1 parent ee33682 commit 94216e3

File tree

5 files changed

+17
-16
lines changed

5 files changed

+17
-16
lines changed

src/app/material-docs-app.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
<app-navbar class="mat-elevation-z6"></app-navbar>
22
<router-outlet></router-outlet>
3-
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
<div class="docs-primary-header component-page-header">
1+
<header class="docs-primary-header component-page-header">
22
<button mat-button class="sidenav-toggle" (click)="toggleSidenav.emit()">
33
<mat-icon>menu</mat-icon>
44
</button>
55

66
<h1 focusOnNavigation>{{getTitle()}} </h1>
7-
</div>
7+
</header>

src/app/pages/component-sidenav/component-sidenav.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@
1111
<div class="docs-component-sidenav-content">
1212
<component-page-header (toggleSidenav)="sidenav.toggle()"></component-page-header>
1313
<div class="docs-component-sidenav-inner-content">
14-
<div class="docs-component-sidenav-body-content">
14+
<main class="docs-component-sidenav-body-content">
1515
<!-- If on large screen, menu resides to left of content -->
1616
<app-component-nav
1717
*ngIf="(isScreenSmall | async) === false"
1818
[params]="params">
1919
</app-component-nav>
2020
<router-outlet></router-outlet>
21-
</div>
21+
</main>
2222
<app-footer></app-footer>
2323
</div>
2424
</div>
Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
1-
<div class="docs-primary-header">
1+
<header class="docs-primary-header">
22
<h1>Guides</h1>
3-
</div>
3+
</header>
44

5-
<mat-nav-list class="docs-guide-list">
6-
<a mat-list-item *ngFor="let guide of guideItems.getAllItems()"
7-
class="docs-guide-item"
8-
[routerLink]="['/guide/', guide.id]">
9-
{{guide.name}}
10-
</a>
11-
</mat-nav-list>
5+
<main>
6+
<mat-nav-list class="docs-guide-list">
7+
<a mat-list-item *ngFor="let guide of guideItems.getAllItems()"
8+
class="docs-guide-item"
9+
[routerLink]="['/guide/', guide.id]">
10+
{{guide.name}}
11+
</a>
12+
</mat-nav-list>
13+
</main>
1214

1315
<app-footer></app-footer>

src/app/pages/homepage/homepage.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ <h2> Material Design components for Angular</h2>
1111
</div>
1212
</header>
1313

14-
<div class="docs-homepage-promo">
14+
<main class="docs-homepage-promo">
1515
<div class="docs-homepage-row">
1616
<div class="docs-homepage-promo-img">
1717
<docs-svg-viewer src="../assets/img/homepage/sprintzerotoapp.svg"
@@ -60,6 +60,6 @@ <h2>Optimized for Angular</h2>
6060
Get started
6161
</a>
6262
</div>
63-
</div>
63+
</main>
6464

6565
<app-footer></app-footer>

0 commit comments

Comments
 (0)