Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

Commit b0902db

Browse files
committed
Fix forking and saving for webcontainer stackblitz examples
Fixes the forking and saving functionality for WebContainer StackBlitz examples. The saving/forking functionality did not work (no proper error though) because we delivered a binary `.ico` file to StackBlitz. To fix the examples, we will remove the `favicon.ico` file, even the goal was to keep the examples as equivalent as possible to a `ng new`-created app.
1 parent 98deeca commit b0902db

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/app/shared/stack-blitz/stack-blitz-writer.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ const TEMPLATE_PATH = '/assets/stack-blitz/';
2424
/**
2525
* List of boilerplate files for an example StackBlitz.
2626
* This currently matches files needed for a basic Angular CLI project.
27+
*
28+
* Note: The template files match up with a basic app generated through `ng new`.
29+
* StackBlitz does not support binary files like `favicon.ico`, so we removed that
30+
* file from the boilerplate.
2731
*/
2832
export const TEMPLATE_FILES = [
2933
'.gitignore',
@@ -35,7 +39,6 @@ export const TEMPLATE_FILES = [
3539
'tsconfig.app.json',
3640
'tsconfig.json',
3741
'tsconfig.spec.json',
38-
'src/favicon.ico',
3942
'src/index.html',
4043
'src/main.ts',
4144
'src/material.module.ts',

src/assets/stack-blitz/angular.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
"tsConfig": "tsconfig.app.json",
2828
"inlineStyleLanguage": "scss",
2929
"assets": [
30-
"src/favicon.ico",
3130
"src/assets"
3231
],
3332
"styles": [
@@ -99,7 +98,6 @@
9998
"karmaConfig": "karma.conf.js",
10099
"inlineStyleLanguage": "scss",
101100
"assets": [
102-
"src/favicon.ico",
103101
"src/assets"
104102
],
105103
"stylePreprocessorOptions": {

src/assets/stack-blitz/src/index.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
<title>${title}</title>
66
<base href="/">
77
<meta name="viewport" content="width=device-width, initial-scale=1">
8-
<link rel="icon" type="image/x-icon" href="favicon.ico">
98
<link rel="preconnect" href="https://fonts.gstatic.com">
109
<link href="https://fonts.googleapis.com/css2?family=Roboto:wght@300;400;500&display=swap" rel="stylesheet">
1110
<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">

0 commit comments

Comments
 (0)