Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

Commit f354578

Browse files
committed
fix(theme-picker,version-picker): add/improve aria-labels and tooltips
Fixes #671
1 parent 78d555b commit f354578

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

src/app/shared/theme-picker/theme-picker.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
<button mat-icon-button [mat-menu-trigger-for]="themeMenu" matTooltip="Select a theme!"
2-
aria-label="Open menu to select a theme">
1+
<button mat-icon-button [mat-menu-trigger-for]="themeMenu" aria-label="Select a theme"
2+
matTooltip="Select a theme for the documentation">
33
<mat-icon>format_color_fill</mat-icon>
44
</button>
55

src/app/shared/theme-picker/theme-picker.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import {
99
import {StyleManager} from '../style-manager';
1010
import {DocsSiteTheme, ThemeStorage} from './theme-storage/theme-storage';
1111
import {MatButtonModule} from '@angular/material/button';
12-
import {MatGridListModule} from '@angular/material/grid-list';
1312
import {MatIconModule, MatIconRegistry} from '@angular/material/icon';
1413
import {MatMenuModule} from '@angular/material/menu';
1514
import {MatTooltipModule} from '@angular/material/tooltip';
@@ -113,12 +112,11 @@ export class ThemePicker implements OnInit, OnDestroy {
113112

114113
@NgModule({
115114
imports: [
115+
CommonModule,
116116
MatButtonModule,
117117
MatIconModule,
118118
MatMenuModule,
119-
MatGridListModule,
120119
MatTooltipModule,
121-
CommonModule
122120
],
123121
exports: [ThemePicker],
124122
declarations: [ThemePicker],

src/app/shared/version-picker/version-picker.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
<button mat-button [matMenuTriggerFor]="versionPicker">
1+
<button mat-button [matMenuTriggerFor]="versionPicker" aria-label="Select a version"
2+
matTooltip="Select a version of the documentation">
23
{{materialVersion}}
34
<mat-icon>arrow_drop_down</mat-icon>
45
</button>

src/app/shared/version-picker/version-picker.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import {MatButtonModule} from '@angular/material/button';
55
import {MatIconModule} from '@angular/material/icon';
66
import {MatMenuModule} from '@angular/material/menu';
77
import {materialVersion, VersionInfo} from '../version/version';
8+
import {MatTooltipModule} from '@angular/material/tooltip';
89

910
const versionUrl = 'assets/versions.json';
1011

@@ -32,7 +33,7 @@ export class VersionPicker {
3233
}
3334

3435
@NgModule({
35-
imports: [MatButtonModule, MatIconModule, MatMenuModule, CommonModule],
36+
imports: [MatButtonModule, MatIconModule, MatMenuModule, MatTooltipModule, CommonModule],
3637
exports: [VersionPicker],
3738
declarations: [VersionPicker]
3839
})

0 commit comments

Comments
 (0)