Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

refactor: update stackblitz CLI asset to match with CLI rc.2 output #1094

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

devversion
Copy link
Member

cc. @Splaktar

@devversion devversion requested a review from crisbeto October 30, 2021 12:28
@google-cla google-cla bot added the cla: yes label Oct 30, 2021
@devversion devversion force-pushed the stackblitz-boilerplate-rc.2-cli branch from 74160b2 to 93bd346 Compare October 30, 2021 12:34
@devversion devversion force-pushed the stackblitz-boilerplate-rc.2-cli branch from 93bd346 to 81086dc Compare October 30, 2021 12:35
<link href="https://fonts.googleapis.com/css2?family=Roboto:wght@300;400;500&display=swap" rel="stylesheet">
<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">
</head>
<body class="mat-typography mat-app-background">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the ng add schematic on the boilerplate to match what people would have locally. Note that I also added mat-app-background here as the StackBlitz examples do not necessarily use the sidenav (and to make the background work for people tinkering with themes then)

margin: 0;
padding: 30px;
}

.version-info {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note that I removed this as it looks good without the extra CSS as well, and this matches more with the standard CLI project w/ ng add @angular/material then.

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion merged commit 4ceb52d into master Oct 30, 2021
@devversion devversion deleted the stackblitz-boilerplate-rc.2-cli branch February 17, 2022 10:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants