fix: Disable block syntax parsing when no project in workspace supports it

This commit adds a check to ensure any project in the workspace supports
block syntax. If not, the block syntax parsing in the compiler should be
disabled. Note that the language server is shared for all projects in
the workspace. If on supports block syntax, we have to enable it.

fixes #1958

Author: atscott

client/src/client.ts

@@ -432,6 +432,10 @@ function constructArgs(ctx: vscode.ExtensionContext): string[] {
     args.push('--includeCompletionsWithSnippetText');
   }
 
+  if (!anyProjectSupportsBlockSyntax()) {
+    args.push('--disableBlockSyntax');
+  }
+
   const forceStrictTemplates = config.get<boolean>('angular.forceStrictTemplates');
   if (forceStrictTemplates) {
     args.push('--forceStrictTemplates');
@@ -505,3 +509,20 @@ function extensionVersionCompatibleWithAllProjects(serverModuleLocation: string)
   }
   return true;
 }
+
+/**
+ * Returns true if any project in the workspace supports block syntax (v17+).
+ */
+function anyProjectSupportsBlockSyntax() {
+  const workspaceFolders = vscode.workspace.workspaceFolders || [];
+  for (const workspaceFolder of workspaceFolders) {
+    const angularCore = resolve('@angular/core', workspaceFolder.uri.fsPath);
+    if (angularCore === undefined) {
+      continue;
+    }
+    if (angularCore.version.major >= 17) {
+      return true;
+    }
+  }
+  return false;
+}

server/src/cmdline_utils.ts

@@ -36,6 +36,7 @@ interface CommandLineOptions {
   includeAutomaticOptionalChainCompletions: boolean;
   includeCompletionsWithSnippetText: boolean;
   forceStrictTemplates: boolean;
+  disableBlockSyntax: boolean;
 }
 
 export function parseCommandLine(argv: string[]): CommandLineOptions {
@@ -50,6 +51,7 @@ export function parseCommandLine(argv: string[]): CommandLineOptions {
         hasArgument(argv, '--includeAutomaticOptionalChainCompletions'),
     includeCompletionsWithSnippetText: hasArgument(argv, '--includeCompletionsWithSnippetText'),
     forceStrictTemplates: hasArgument(argv, '--forceStrictTemplates'),
+    disableBlockSyntax: hasArgument(argv, '--disableBlockSyntax'),
   };
 }
 

server/src/server.ts

@@ -46,6 +46,7 @@ function main() {
     includeAutomaticOptionalChainCompletions: options.includeAutomaticOptionalChainCompletions,
     includeCompletionsWithSnippetText: options.includeCompletionsWithSnippetText,
     forceStrictTemplates: isG3 || options.forceStrictTemplates,
+    disableBlockSyntax: options.disableBlockSyntax,
   });
 
   // Log initialization info

server/src/session.ts

@@ -33,6 +33,7 @@ export interface SessionOptions {
   includeAutomaticOptionalChainCompletions: boolean;
   includeCompletionsWithSnippetText: boolean;
   forceStrictTemplates: boolean;
+  disableBlockSyntax: boolean;
 }
 
 enum LanguageId {
@@ -156,6 +157,9 @@ export class Session {
     if (options.forceStrictTemplates) {
       pluginConfig.forceStrictTemplates = true;
     }
+    if (options.disableBlockSyntax) {
+      (pluginConfig as any).enableBlockSyntax = false;
+    }
     projSvc.configurePlugin({
       pluginName: options.ngPlugin,
       configuration: pluginConfig,