Skip to content

Commit 5df07f1

Browse files
committed
build: update circleci node version to v16.10.0
1 parent 924b5e5 commit 5df07f1

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

.circleci/config.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@ orbs:
33
node: circleci/[email protected]
44
jobs:
55
build-and-test:
6-
executor:
7-
name: node/default
8-
tag: '12.18'
6+
docker:
7+
- image: cimg/node:16.10.0-browsers@sha256:83ff2dcad3043c4b3f7f58513805a0c8757ba5541a1f3c213f80bd242a3c77ac
98
steps:
109
- checkout
1110
- node/install-packages:

scripts/build.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,11 @@ cp syntaxes/!(tsconfig).json dist/npm/syntaxes
2525
pushd dist/npm
2626
# TODO(kyliau): vsce does not bundle nested node_modules due to bug
2727
# https://github.com/microsoft/vscode-vsce/issues/432 so install using NPM for now.
28-
npm install --production --ignore-scripts
28+
# Note: We also use `--force` as NPM incorrectly checks the dev dependencies even
29+
# though we have limited the install to production-only dependencies. We know that
30+
# our versions are compatible from the Yarn install, so it's acceptable to force proceed
31+
# on peer dependency conflicts (like `tslint@6` not being supported by `tslint-eslint-rules`).
32+
npm install --production --ignore-scripts --force
2933

3034
sed -i -e 's#./dist/client/extension#./index#' package.json
3135
../../node_modules/.bin/vsce package

0 commit comments

Comments
 (0)