Skip to content

Commit dfe2bb8

Browse files
gregmagolanatscott
authored andcommitted
fix: add v12_language_service/node_modules to release package (#1826)
* build: add missing vscode-nls to npm_translate_lock hoisted package * fix: add v12_language_service/node_modules to release package (cherry picked from commit a7cde7e)
1 parent f0bfd2a commit dfe2bb8

File tree

4 files changed

+15
-0
lines changed

4 files changed

+15
-0
lines changed

.bazelignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
node_modules/
2+
v12_language_service/node_modules
23
dist/
34
integration/pre_apf_project/node_modules/
45
integration/project/node_modules/

WORKSPACE

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,10 @@ npm_translate_lock(
7373
yarn_lock = "//:yarn.lock",
7474
package_json = "//:package.json",
7575
npmrc = "//:.npmrc",
76+
data = [
77+
"//:pnpm-workspace.yaml",
78+
"//v12_language_service:package.json",
79+
],
7680
verify_node_modules_ignored = "//:.bazelignore",
7781
public_hoist_packages = {
7882
# Hoist transitive closure of npm deps needed for vsce; this set was determined manually by

pnpm-workspace.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
packages:
2+
- v12_language_service

v12_language_service/BUILD.bazel

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,16 @@
1+
load("@npm//:defs.bzl", "npm_link_all_packages")
2+
3+
npm_link_all_packages(name = "node_modules")
4+
15
filegroup(
26
name = "npm_files",
37
srcs = [
48
"package.json",
59
"yarn.lock",
10+
# There are needed for backward compat with Angular v12.
11+
# See https://github.com/angular/vscode-ng-language-service/issues/1821.
12+
":node_modules/@angular/language-service",
13+
":node_modules/@angular/language-server",
614
],
715
visibility = ["//:__pkg__"],
816
)

0 commit comments

Comments
 (0)