Refactor no-relative-paths tests (#3270)

Author: ssbarnea

examples/playbooks/no_relative_paths_fail.yml

@@ -0,0 +1,23 @@
+---
+- name: Fixture for no-relative-paths
+  hosts: localhost
+  tasks:
+    - name: Template example # <-- 1st
+      ansible.builtin.template:
+        src: ../templates/foo.j2
+        dest: /etc/file.conf
+        mode: "0644"
+    - name: Copy example # <-- 2nd
+      ansible.builtin.copy:
+        src: ../files/foo.conf
+        dest: /etc/foo.conf
+        mode: "0644"
+    # Removed from test suite as module is no longer part of core
+    # - name: Some win_template example
+    #   win_template:
+    #     src: ../win_templates/file.conf.j2
+    #     dest: file.conf
+    # - name: Some win_copy example
+    #   win_copy:
+    #     src: ../files/foo.conf
+    #     dest: renamed-foo.conf

examples/playbooks/no_relative_paths_pass.yml

@@ -0,0 +1,14 @@
+---
+- name: Fixture for no-relative-paths
+  hosts: localhost
+  tasks:
+    - name: Content example with no src
+      ansible.builtin.copy:
+        content: "# This file was moved to /etc/other.conf"
+        dest: /etc/mine.conf
+        mode: "0644"
+    - name: Copy example
+      ansible.builtin.copy:
+        src: /home/example/files/foo.conf
+        dest: /etc/foo.conf
+        mode: "0644"

examples/roles/fixture_1/tasks/main.yml

@@ -1,21 +1,21 @@
 ---
 - name: Bad git 1 # noqa: latest[git]
-  action: ansible.builtin.git repo=foo clone=no
+  action: ansible.builtin.git repo=. clone=no
 - name: Bad git 2 <-- 1st
-  action: ansible.builtin.git repo=foo clone=no
+  action: ansible.builtin.git repo=. clone=no
 - name: Block with rescue and always section
   block:
     - name: Bad git 3 # noqa: latest[git]
-      action: ansible.builtin.git repo=foo clone=no
+      action: ansible.builtin.git repo=. clone=no
     - name: Bad git 4 <-- 2nd
-      action: ansible.builtin.git repo=foo clone=no
+      action: ansible.builtin.git repo=. clone=no
   rescue:
     - name: Bad git 5 # noqa: latest[git]
-      action: ansible.builtin.git repo=foo clone=no
+      action: ansible.builtin.git repo=. clone=no
     - name: Bad git 6 <-- 3rd
-      action: ansible.builtin.git repo=foo clone=no
+      action: ansible.builtin.git repo=. clone=no
   always:
     - name: Bad git 7 # noqa: latest[git]
-      action: ansible.builtin.git repo=foo clone=no
+      action: ansible.builtin.git repo=. clone=no
     - name: Bad git 8 <-- 4th
-      action: ansible.builtin.git repo=foo clone=no
+      action: ansible.builtin.git repo=. clone=no

src/ansiblelint/rules/no_relative_paths.py

@@ -4,6 +4,7 @@
 
 from __future__ import annotations
 
+import sys
 from typing import TYPE_CHECKING, Any
 
 from ansiblelint.rules import AnsibleLintRule
@@ -43,3 +44,27 @@ def matchtask(
             return True
 
         return False
+
+
+# testing code to be loaded only with pytest or when executed the rule file
+if "pytest" in sys.modules:
+    import pytest
+
+    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
+    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+
+    @pytest.mark.parametrize(
+        ("test_file", "failures"),
+        (
+            pytest.param("examples/playbooks/no_relative_paths_fail.yml", 2, id="fail"),
+            pytest.param("examples/playbooks/no_relative_paths_pass.yml", 0, id="pass"),
+        ),
+    )
+    def test_no_relative_paths(
+        default_rules_collection: RulesCollection, test_file: str, failures: int
+    ) -> None:
+        """Test rule matches."""
+        results = Runner(test_file, rules=default_rules_collection).run()
+        assert len(results) == failures
+        for result in results:
+            assert result.tag == "no-relative-paths"