Skip to content

Commit cb5f792

Browse files
kazutakahirataAnthony Tran
authored andcommitted
[AMDGPU] Drop const from return types (NFC) (llvm#145640)
We don't need const on these return types.
1 parent d72f969 commit cb5f792

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

llvm/lib/Target/AMDGPU/AMDGPURegBankLegalizeHelper.cpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -171,25 +171,22 @@ void RegBankLegalizeHelper::lowerVccExtToSel(MachineInstr &MI) {
171171
MI.eraseFromParent();
172172
}
173173

174-
const std::pair<Register, Register>
175-
RegBankLegalizeHelper::unpackZExt(Register Reg) {
174+
std::pair<Register, Register> RegBankLegalizeHelper::unpackZExt(Register Reg) {
176175
auto PackedS32 = B.buildBitcast(SgprRB_S32, Reg);
177176
auto Mask = B.buildConstant(SgprRB_S32, 0x0000ffff);
178177
auto Lo = B.buildAnd(SgprRB_S32, PackedS32, Mask);
179178
auto Hi = B.buildLShr(SgprRB_S32, PackedS32, B.buildConstant(SgprRB_S32, 16));
180179
return {Lo.getReg(0), Hi.getReg(0)};
181180
}
182181

183-
const std::pair<Register, Register>
184-
RegBankLegalizeHelper::unpackSExt(Register Reg) {
182+
std::pair<Register, Register> RegBankLegalizeHelper::unpackSExt(Register Reg) {
185183
auto PackedS32 = B.buildBitcast(SgprRB_S32, Reg);
186184
auto Lo = B.buildSExtInReg(SgprRB_S32, PackedS32, 16);
187185
auto Hi = B.buildAShr(SgprRB_S32, PackedS32, B.buildConstant(SgprRB_S32, 16));
188186
return {Lo.getReg(0), Hi.getReg(0)};
189187
}
190188

191-
const std::pair<Register, Register>
192-
RegBankLegalizeHelper::unpackAExt(Register Reg) {
189+
std::pair<Register, Register> RegBankLegalizeHelper::unpackAExt(Register Reg) {
193190
auto PackedS32 = B.buildBitcast(SgprRB_S32, Reg);
194191
auto Lo = PackedS32;
195192
auto Hi = B.buildLShr(SgprRB_S32, PackedS32, B.buildConstant(SgprRB_S32, 16));

llvm/lib/Target/AMDGPU/AMDGPURegBankLegalizeHelper.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,9 @@ class RegBankLegalizeHelper {
111111
SmallSet<Register, 4> &SgprWaterfallOperandRegs);
112112

113113
void lowerVccExtToSel(MachineInstr &MI);
114-
const std::pair<Register, Register> unpackZExt(Register Reg);
115-
const std::pair<Register, Register> unpackSExt(Register Reg);
116-
const std::pair<Register, Register> unpackAExt(Register Reg);
114+
std::pair<Register, Register> unpackZExt(Register Reg);
115+
std::pair<Register, Register> unpackSExt(Register Reg);
116+
std::pair<Register, Register> unpackAExt(Register Reg);
117117
void lowerUnpackBitShift(MachineInstr &MI);
118118
void lowerV_BFE(MachineInstr &MI);
119119
void lowerS_BFE(MachineInstr &MI);

0 commit comments

Comments
 (0)