Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit 0c0cd3e

Browse files
mrhpearsonjwrdegoede
authored andcommitted
platform/x86: thinkpad_acpi: Fix platform profiles on T490
I had incorrectly thought that PSC profiles were not usable on Intel platforms so had blocked them in the driver initialistion. This broke platform profiles on the T490. After discussion with the FW team PSC does work on Intel platforms and should be allowed. Note - it's possible this may impact other platforms where it is advertised but special driver support that only Windows has is needed. But if it does then they will need fixing via quirks. Please report any issues to me so I can get them addressed - but I haven't found any problems in testing...yet Fixes: bce6243 ("platform/x86: thinkpad_acpi: do not use PSC mode on Intel platforms") Link: https://bugzilla.redhat.com/show_bug.cgi?id=2177962 Cc: [email protected] Signed-off-by: Mark Pearson <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Hans de Goede <[email protected]> Signed-off-by: Hans de Goede <[email protected]>
1 parent decab28 commit 0c0cd3e

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

drivers/platform/x86/thinkpad_acpi.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10593,11 +10593,6 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm)
1059310593
dytc_mmc_get_available = true;
1059410594
}
1059510595
} else if (dytc_capabilities & BIT(DYTC_FC_PSC)) { /* PSC MODE */
10596-
/* Support for this only works on AMD platforms */
10597-
if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD) {
10598-
dbg_printk(TPACPI_DBG_INIT, "PSC not support on Intel platforms\n");
10599-
return -ENODEV;
10600-
}
1060110596
pr_debug("PSC is supported\n");
1060210597
} else {
1060310598
dbg_printk(TPACPI_DBG_INIT, "No DYTC support available\n");

0 commit comments

Comments
 (0)