Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit 50bb17d

Browse files
gregkhTreehugger Robot
authored andcommitted
Revert "mpls: Handle error of rtnl_register_module()."
This reverts commit 4597c38 which is commit 5be2062 upstream. It breaks the Android kernel abi and can be brought back in the future in an abi-safe way if it is really needed. Bug: 161946584 Change-Id: I53b9129740fcf7a9a89ac36fc74510dfff93728e Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 8527422 commit 50bb17d

File tree

1 file changed

+11
-21
lines changed

1 file changed

+11
-21
lines changed

net/mpls/af_mpls.c

Lines changed: 11 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2729,15 +2729,6 @@ static struct rtnl_af_ops mpls_af_ops __read_mostly = {
27292729
.get_stats_af_size = mpls_get_stats_af_size,
27302730
};
27312731

2732-
static const struct rtnl_msg_handler mpls_rtnl_msg_handlers[] __initdata_or_module = {
2733-
{THIS_MODULE, PF_MPLS, RTM_NEWROUTE, mpls_rtm_newroute, NULL, 0},
2734-
{THIS_MODULE, PF_MPLS, RTM_DELROUTE, mpls_rtm_delroute, NULL, 0},
2735-
{THIS_MODULE, PF_MPLS, RTM_GETROUTE, mpls_getroute, mpls_dump_routes, 0},
2736-
{THIS_MODULE, PF_MPLS, RTM_GETNETCONF,
2737-
mpls_netconf_get_devconf, mpls_netconf_dump_devconf,
2738-
RTNL_FLAG_DUMP_UNLOCKED},
2739-
};
2740-
27412732
static int __init mpls_init(void)
27422733
{
27432734
int err;
@@ -2756,25 +2747,24 @@ static int __init mpls_init(void)
27562747

27572748
rtnl_af_register(&mpls_af_ops);
27582749

2759-
err = rtnl_register_many(mpls_rtnl_msg_handlers);
2760-
if (err)
2761-
goto out_unregister_rtnl_af;
2762-
2750+
rtnl_register_module(THIS_MODULE, PF_MPLS, RTM_NEWROUTE,
2751+
mpls_rtm_newroute, NULL, 0);
2752+
rtnl_register_module(THIS_MODULE, PF_MPLS, RTM_DELROUTE,
2753+
mpls_rtm_delroute, NULL, 0);
2754+
rtnl_register_module(THIS_MODULE, PF_MPLS, RTM_GETROUTE,
2755+
mpls_getroute, mpls_dump_routes, 0);
2756+
rtnl_register_module(THIS_MODULE, PF_MPLS, RTM_GETNETCONF,
2757+
mpls_netconf_get_devconf,
2758+
mpls_netconf_dump_devconf,
2759+
RTNL_FLAG_DUMP_UNLOCKED);
27632760
err = ipgre_tunnel_encap_add_mpls_ops();
2764-
if (err) {
2761+
if (err)
27652762
pr_err("Can't add mpls over gre tunnel ops\n");
2766-
goto out_unregister_rtnl;
2767-
}
27682763

27692764
err = 0;
27702765
out:
27712766
return err;
27722767

2773-
out_unregister_rtnl:
2774-
rtnl_unregister_many(mpls_rtnl_msg_handlers);
2775-
out_unregister_rtnl_af:
2776-
rtnl_af_unregister(&mpls_af_ops);
2777-
dev_remove_pack(&mpls_packet_type);
27782768
out_unregister_pernet:
27792769
unregister_pernet_subsys(&mpls_net_ops);
27802770
goto out;

0 commit comments

Comments
 (0)