Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit 847f07e

Browse files
gregkhTreehugger Robot
authored andcommitted
Revert "phonet: Handle error of rtnl_register_module()."
This reverts commit c246bfb which is commit b5e837c upstream. It breaks the Android kernel abi and can be brought back in the future in an abi-safe way if it is really needed. Bug: 161946584 Change-Id: If5b15f11c6ae4a1443534942fe38cc050cb433b7 Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent ced98dd commit 847f07e

File tree

1 file changed

+17
-11
lines changed

1 file changed

+17
-11
lines changed

net/phonet/pn_netlink.c

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -285,17 +285,23 @@ static int route_dumpit(struct sk_buff *skb, struct netlink_callback *cb)
285285
return err;
286286
}
287287

288-
static const struct rtnl_msg_handler phonet_rtnl_msg_handlers[] __initdata_or_module = {
289-
{THIS_MODULE, PF_PHONET, RTM_NEWADDR, addr_doit, NULL, 0},
290-
{THIS_MODULE, PF_PHONET, RTM_DELADDR, addr_doit, NULL, 0},
291-
{THIS_MODULE, PF_PHONET, RTM_GETADDR, NULL, getaddr_dumpit, 0},
292-
{THIS_MODULE, PF_PHONET, RTM_NEWROUTE, route_doit, NULL, 0},
293-
{THIS_MODULE, PF_PHONET, RTM_DELROUTE, route_doit, NULL, 0},
294-
{THIS_MODULE, PF_PHONET, RTM_GETROUTE, NULL, route_dumpit,
295-
RTNL_FLAG_DUMP_UNLOCKED},
296-
};
297-
298288
int __init phonet_netlink_register(void)
299289
{
300-
return rtnl_register_many(phonet_rtnl_msg_handlers);
290+
int err = rtnl_register_module(THIS_MODULE, PF_PHONET, RTM_NEWADDR,
291+
addr_doit, NULL, 0);
292+
if (err)
293+
return err;
294+
295+
/* Further rtnl_register_module() cannot fail */
296+
rtnl_register_module(THIS_MODULE, PF_PHONET, RTM_DELADDR,
297+
addr_doit, NULL, 0);
298+
rtnl_register_module(THIS_MODULE, PF_PHONET, RTM_GETADDR,
299+
NULL, getaddr_dumpit, 0);
300+
rtnl_register_module(THIS_MODULE, PF_PHONET, RTM_NEWROUTE,
301+
route_doit, NULL, 0);
302+
rtnl_register_module(THIS_MODULE, PF_PHONET, RTM_DELROUTE,
303+
route_doit, NULL, 0);
304+
rtnl_register_module(THIS_MODULE, PF_PHONET, RTM_GETROUTE,
305+
NULL, route_dumpit, RTNL_FLAG_DUMP_UNLOCKED);
306+
return 0;
301307
}

0 commit comments

Comments
 (0)