um: virt-pci: fix missing declaration warning

vwax · richardweinberger · commit 974b808d85ab · 2023-08-26T22:49:49.000+02:00
Fix this warning which appears with W=1 and without CONFIG_OF: warning: no previous declaration for 'pcibios_get_phb_of_node' Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202308230949.PphIIlhq-lkp@intel.com/ Fixes: 314a140 ("um: virt-pci: implement pcibios_get_phb_of_node()") Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> Signed-off-by: Richard Weinberger <richard@nod.at>
diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c
@@ -544,6 +544,7 @@ static void um_pci_irq_vq_cb(struct virtqueue *vq)
 	}
 }
 
+#ifdef CONFIG_OF
 /* Copied from arch/x86/kernel/devicetree.c */
 struct device_node *pcibios_get_phb_of_node(struct pci_bus *bus)
 {
@@ -562,6 +563,7 @@ struct device_node *pcibios_get_phb_of_node(struct pci_bus *bus)
 	}
 	return NULL;
 }
+#endif
 
 static int um_pci_init_vqs(struct um_pci_device *dev)
 {

Original file line number	Diff line number	Diff line change
`@@ -544,6 +544,7 @@ static void um_pci_irq_vq_cb(struct virtqueue *vq)`
`544`	`544`	`}`
`545`	`545`	`}`
`546`	`546`
	`547`	`+#ifdef CONFIG_OF`
`547`	`548`	`/* Copied from arch/x86/kernel/devicetree.c */`
`548`	`549`	`struct device_node pcibios_get_phb_of_node(struct pci_bus bus)`
`549`	`550`	`{`
`@@ -562,6 +563,7 @@ struct device_node pcibios_get_phb_of_node(struct pci_bus bus)`
`562`	`563`	`}`
`563`	`564`	`return NULL;`
`564`	`565`	`}`
	`566`	`+#endif`
`565`	`567`
`566`	`568`	`static int um_pci_init_vqs(struct um_pci_device *dev)`
`567`	`569`	`{`