Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit b97e583

Browse files
AstralBobAndreas Gruenbacher
authored andcommitted
gfs2: Issue message when revokes cannot be written
Before this patch, function gfs2_ail_empty_gl would silently return an error to the caller. This would get silently set into sd_log_error which would cause a withdraw, but there was no indication why the file system was withdrawn. This patch adds a fs_err to log the appropriate error message. Signed-off-by: Bob Peterson <[email protected]> Signed-off-by: Andreas Gruenbacher <[email protected]>
1 parent 68ca088 commit b97e583

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

fs/gfs2/glops.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,10 @@ static int gfs2_ail_empty_gl(struct gfs2_glock *gl)
124124
memset(&tr, 0, sizeof(tr));
125125
set_bit(TR_ONSTACK, &tr.tr_flags);
126126
ret = __gfs2_trans_begin(&tr, sdp, 0, revokes, _RET_IP_);
127-
if (ret)
127+
if (ret) {
128+
fs_err(sdp, "Transaction error %d: Unable to write revokes.", ret);
128129
goto flush;
130+
}
129131
__gfs2_ail_flush(gl, 0, revokes);
130132
gfs2_trans_end(sdp);
131133

0 commit comments

Comments
 (0)