(LOG4NET-671) Dispose WindowsIdentity in TryGetCurrentUserName()

erikmav · erikmav · commit 6ad127beb564 · 2021-12-01T13:46:33.000-08:00
diff --git a/src/log4net/Core/LoggingEvent.cs b/src/log4net/Core/LoggingEvent.cs
@@ -931,8 +931,10 @@ private static string TryGetCurrentUserName()
 
             try
             {
-                var windowsIdentity = WindowsIdentity.GetCurrent();
-                return windowsIdentity?.Name ?? "";
+                using (WindowsIdentity windowsIdentity = WindowsIdentity.GetCurrent())
+                {
+                    return windowsIdentity?.Name ?? "";
+                }
             }
             catch (PlatformNotSupportedException)
             {

Original file line number	Diff line number	Diff line change
`@@ -931,8 +931,10 @@ private static string TryGetCurrentUserName()`
`931`	`931`
`932`	`932`	`try`
`933`	`933`	`{`
`934`		`- var windowsIdentity = WindowsIdentity.GetCurrent();`
`935`		`- return windowsIdentity?.Name ?? "";`
	`934`	`+ using (WindowsIdentity windowsIdentity = WindowsIdentity.GetCurrent())`
	`935`	`+ {`
	`936`	`+ return windowsIdentity?.Name ?? "";`
	`937`	`+ }`
`936`	`938`	`}`
`937`	`939`	`catch (PlatformNotSupportedException)`
`938`	`940`	`{`