change signature of setRouteCollections #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@germ1f thank you for finding this out. I tried to reproduce but with no luck. A stack trace might help here. Can add a full stack trace which might help to reproduce it. |
christoph-kluge
previously approved these changes
Aug 31, 2022
christoph-kluge
approved these changes
Aug 31, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello dingo-api team !
I have a suggest to apply : change signature setRouteCollection (cf commit) because getRoutes into https://github.com/api-ecosystem-for-laravel/dingo-api/blob/master/src/Routing/Router.php#L693 can be a collection, I don't know how to reproduce the bug in the tests to show you (i need more time for that).
Sorry if my PR is not perfect, this bug appeared when I upgraded to Laravel 9 and php8 and changes dingo-api package with your.
Thanks for your answers