Merge pull request #1101 from soyuka/fix/stringifyable-identifier

fix stringifyable identifier

Author: dunglas

features/main/uuid.feature

@@ -78,6 +78,24 @@ Feature: Using uuid identifier on resource
     }
     """
 
+  Scenario: Create a resource with custom id generator
+    When I add "Content-Type" header equal to "application/ld+json"
+    And I send a "POST" request to "/custom_generated_identifiers" with body:
+    """
+    {}
+    """
+    Then the response status code should be 201
+    And the response should be in JSON
+    And the header "Content-Type" should be equal to "application/ld+json; charset=utf-8"
+    And the JSON should be equal to:
+    """
+    {
+      "@context": "/contexts/CustomGeneratedIdentifier",
+      "@id": "/custom_generated_identifiers/foo",
+      "@type": "CustomGeneratedIdentifier",
+      "id": "foo"
+    }
+    """
 
   @dropSchema
   Scenario: Delete a resource

src/Bridge/Symfony/Routing/IriConverter.php

@@ -122,14 +122,17 @@ private function getIdentifiersFromItem($item): array
                 continue;
             }
 
-            $identifiers[$propertyName] = $this->propertyAccessor->getValue($item, $propertyName);
+            $identifier = $identifiers[$propertyName] = $this->propertyAccessor->getValue($item, $propertyName);
 
-            if (!is_object($identifiers[$propertyName])) {
+            if (!is_object($identifier)) {
+                continue;
+            } elseif (method_exists($identifier, '__toString')) {
+                $identifiers[$propertyName] = (string) $identifier;
                 continue;
             }
 
-            $relatedResourceClass = $this->getObjectClass($identifiers[$propertyName]);
-            $relatedItem = $identifiers[$propertyName];
+            $relatedResourceClass = $this->getObjectClass($identifier);
+            $relatedItem = $identifier;
 
             unset($identifiers[$propertyName]);
 

tests/Fixtures/TestBundle/Doctrine/Generator/Uuid.php

@@ -0,0 +1,29 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Core\Tests\Fixtures\TestBundle\Doctrine\Generator;
+
+class Uuid
+{
+    private $id;
+
+    public function __construct()
+    {
+        $this->id = 'foo';
+    }
+
+    public function __toString()
+    {
+        return $this->id;
+    }
+}

tests/Fixtures/TestBundle/Doctrine/Generator/UuidGenerator.php

@@ -0,0 +1,25 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Core\Tests\Fixtures\TestBundle\Doctrine\Generator;
+
+use Doctrine\ORM\EntityManager;
+use Doctrine\ORM\Id\AbstractIdGenerator;
+
+class UuidGenerator extends AbstractIdGenerator
+{
+    public function generate(EntityManager $em, $entity): Uuid
+    {
+        return new Uuid();
+    }
+}

tests/Fixtures/TestBundle/Entity/CustomGeneratedIdentifier.php

@@ -0,0 +1,42 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity;
+
+use ApiPlatform\Core\Annotation\ApiResource;
+use ApiPlatform\Core\Tests\Fixtures\TestBundle\Doctrine\Generator\Uuid;
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * Custom identifier.
+ *
+ * @ApiResource
+ * @ORM\Entity
+ */
+class CustomGeneratedIdentifier
+{
+    /**
+     * @var Uuid
+     *
+     * @ORM\Id
+     * @ORM\Column(type="string")
+     * @ORM\GeneratedValue(strategy="CUSTOM")
+     * @ORM\CustomIdGenerator(class="ApiPlatform\Core\Tests\Fixtures\TestBundle\Doctrine\Generator\UuidGenerator")
+     */
+    private $id;
+
+    public function getId()
+    {
+        return (string) $this->id;
+    }
+}