Skip to content

Commit 256c4bf

Browse files
committed
Corrected CS style and applied suggestions
1 parent 7d2e47c commit 256c4bf

File tree

4 files changed

+16
-15
lines changed

4 files changed

+16
-15
lines changed

src/GraphQl/Resolver/Stage/SecurityPostDenormalizeStage.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function __invoke(string $resourceClass, string $operationName, array $co
4545

4646
$isGranted = $resourceMetadata->getGraphqlAttribute($operationName, 'security_post_denormalize', null, true);
4747

48-
if (null === $this->resourceAccessChecker && $isGranted) {
48+
if (null !== $isGranted && null === $this->resourceAccessChecker) {
4949
throw new \LogicException('Cannot check security expression when SecurityBundle is not installed. Try running "composer require symfony/security-bundle".');
5050
}
5151

src/GraphQl/Resolver/Stage/SecurityStage.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ public function __invoke(string $resourceClass, string $operationName, array $co
4444
$resourceMetadata = $this->resourceMetadataFactory->create($resourceClass);
4545

4646
$isGranted = $resourceMetadata->getGraphqlAttribute($operationName, 'security', null, true);
47-
if (null === $this->resourceAccessChecker && $isGranted) {
47+
48+
if (null !== $isGranted && null === $this->resourceAccessChecker) {
4849
throw new \LogicException('Cannot check security expression when SecurityBundle is not installed. Try running "composer require symfony/security-bundle".');
4950
}
5051

tests/GraphQl/Resolver/Stage/SecurityPostDenormalizeStageTest.php

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -129,20 +129,14 @@ public function testNoSecurityBundleInstalled(): void
129129
);
130130
$this->resourceMetadataFactoryProphecy->create($resourceClass)->willReturn($resourceMetadata);
131131

132-
$this->securityPostDenormalizeStage = new SecurityPostDenormalizeStage(
133-
$this->resourceMetadataFactoryProphecy->reveal(), null
134-
);
132+
$this->securityPostDenormalizeStage = new SecurityPostDenormalizeStage($this->resourceMetadataFactoryProphecy->reveal(), null);
135133

136134
$info = $this->prophesize(ResolveInfo::class)->reveal();
137135
$this->expectException(\LogicException::class);
138136

139-
($this->securityPostDenormalizeStage)(
140-
$resourceClass,
141-
'item_query',
142-
[
143-
'info' => $info,
144-
'extra_variables' => $extraVariables,
145-
]
146-
);
137+
($this->securityPostDenormalizeStage)($resourceClass,'item_query', [
138+
'info' => $info,
139+
'extra_variables' => $extraVariables,
140+
]);
147141
}
148142
}

tests/GraphQl/Resolver/Stage/SecurityStageTest.php

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,15 @@ public function testNoSecurityBundleInstalled(): void
105105
$resourceClass = 'myResource';
106106
$isGranted = 'not_granted';
107107
$extraVariables = ['extra' => false];
108-
$resourceMetadata = (new ResourceMetadata())->withGraphql([$operationName => ['security' => $isGranted]]);
108+
$resourceMetadata = (new ResourceMetadata())->withGraphql([
109+
$operationName => ['security' => $isGranted],
110+
]);
109111
$this->resourceMetadataFactoryProphecy->create($resourceClass)->willReturn($resourceMetadata);
112+
110113
$this->expectException(\LogicException::class);
111-
($this->securityStage)($resourceClass, 'item_query', ['extra_variables' => $extraVariables]);
114+
115+
($this->securityStage)($resourceClass, 'item_query', [
116+
'extra_variables' => $extraVariables
117+
]);
112118
}
113119
}

0 commit comments

Comments
 (0)