Merge pull request #1698 from antograssiot/avoid-filter-deprecation

Fix deprecation notice on filters applied on collection without params

Author: dunglas

src/Bridge/Doctrine/Orm/Extension/FilterExtension.php

@@ -65,6 +65,8 @@ public function applyToCollection(QueryBuilder $queryBuilder, QueryNameGenerator
                 continue;
             }
 
+            $context['filters'] = $context['filters'] ?? [];
+
             $filter->apply($queryBuilder, $queryNameGenerator, $resourceClass, $operationName, $context);
         }
     }

tests/Bridge/Doctrine/Orm/Extension/FilterExtensionTest.php

@@ -41,7 +41,7 @@ public function testApplyToCollectionWithValidFilters()
         $queryBuilder = $queryBuilderProphecy->reveal();
 
         $ormFilterProphecy = $this->prophesize(FilterInterface::class);
-        $ormFilterProphecy->apply($queryBuilder, new QueryNameGenerator(), Dummy::class, 'get', [])->shouldBeCalled();
+        $ormFilterProphecy->apply($queryBuilder, new QueryNameGenerator(), Dummy::class, 'get', ['filters' => []])->shouldBeCalled();
 
         $ordinaryFilterProphecy = $this->prophesize(ApiFilterInterface::class);
 
@@ -70,7 +70,7 @@ public function testApplyToCollectionWithValidFiltersAndDeprecatedFilterCollecti
         $queryBuilder = $queryBuilderProphecy->reveal();
 
         $filterProphecy = $this->prophesize(FilterInterface::class);
-        $filterProphecy->apply($queryBuilder, new QueryNameGenerator(), Dummy::class, 'get', [])->shouldBeCalled();
+        $filterProphecy->apply($queryBuilder, new QueryNameGenerator(), Dummy::class, 'get', ['filters' => []])->shouldBeCalled();
 
         $orderExtensionTest = new FilterExtension($resourceMetadataFactoryProphecy->reveal(), new FilterCollection(['dummyFilter' => $filterProphecy->reveal()]));
         $orderExtensionTest->applyToCollection($queryBuilder, new QueryNameGenerator(), Dummy::class, 'get');