Merge pull request #1547 from jdeniau/fix-relationWithWrongIri

Fix: Passing nor an unknown iri nor an array in an embedded relation throws an error

Author: dunglas

features/main/relation.feature

@@ -442,3 +442,28 @@ Feature: Relations support
       "related": null
     }
     """
+
+  Scenario: Issue #1547 Passing wrong argument to a relation
+    When I add "Content-Type" header equal to "application/ld+json"
+    And I send a "POST" request to "/relation_embedders" with body:
+    """
+    {
+      "related": "certainly not an iri"
+    }
+    """
+    Then the response status code should be 400
+    And the response should be in JSON
+    And the header "Content-Type" should be equal to "application/ld+json; charset=utf-8"
+    And the JSON node "hydra:description" should contain "Expected IRI or nested document"
+
+    When I add "Content-Type" header equal to "application/ld+json"
+    And I send a "POST" request to "/relation_embedders" with body:
+    """
+    {
+      "related": 8
+    }
+    """
+    Then the response status code should be 400
+    And the response should be in JSON
+    And the header "Content-Type" should be equal to "application/ld+json; charset=utf-8"
+    And the JSON node "hydra:description" should contain "Expected IRI or nested document"

src/Serializer/AbstractItemNormalizer.php

@@ -285,7 +285,10 @@ private function denormalizeRelation(string $attributeName, PropertyMetadata $pr
             }
         }
 
-        if (!$this->resourceClassResolver->isResourceClass($className) || $propertyMetadata->isWritableLink()) {
+        if (
+            !$this->resourceClassResolver->isResourceClass($className) ||
+            ($propertyMetadata->isWritableLink() && is_array($value))
+        ) {
             return $this->serializer->denormalize($value, $className, $format, $this->createRelationSerializationContext($className, $context));
         }