improve source with @dunglas comments.

Author: odoucet

src/Bridge/Doctrine/Orm/Filter/SearchFilter.php

@@ -146,25 +146,23 @@ protected function filterProperty(string $property, $value, QueryBuilder $queryB
              */
 
             // let's do a very simple query if we don't need the complex one (99% of time)
-            if (\in_array($metadata->getTypeOfField($field), ['string', 'integer'], true)) {
+            $type = $metadata->getTypeOfField($field);
+            if (\in_array($type, ['string', 'integer'], true)) {
                 $queryBuilder
                     ->andWhere(sprintf($wrapCase('%s.%s').' IN (:%s)', $alias, $field, $valueParameter))
                     ->setParameter($valueParameter, $caseSensitive ? $values : array_map('strtolower', $values));
             } else {
                 $inQuery = [];
-                $args = [];
-                $type = $metadata->getTypeOfField($field);
+                $nbArgs = \count($values);
+
+                // QueryBuilder->setParameters() reset current parameters set, so we need to merge them all together
+                $parameters = $queryBuilder->getParameters();
 
-                for ($i = 0; $i < \count($values); ++$i) {
+                for ($i = 0; $i < $nbArgs; ++$i) {
                     $inQuery[] = ':filterproperty'.$i;
-                    $args[] = new Parameter('filterproperty'.$i, $caseSensitive ? $values[$i] : strtolower($values[$i]), $type);
+                    $parameters->add(new Parameter('filterproperty'.$i, $caseSensitive ? $values[$i] : strtolower($values[$i]), $type));
                 }
 
-                // setParameters reset current parameters set, so we need to merge with getParameters()
-                $parameters = new ArrayCollection($args);
-                foreach ($queryBuilder->getParameters() as $p) {
-                    $parameters->add($p);
-                }
                 $queryBuilder
                     ->andWhere(sprintf($wrapCase('%s.%s').' IN (%s)', $alias, $field, implode(',', $inQuery)))
                     ->setParameters($parameters);
@@ -220,10 +218,10 @@ protected function filterProperty(string $property, $value, QueryBuilder $queryB
      *
      * @throws InvalidArgumentException If strategy does not exist
      */
-    protected function addWhereByStrategy(string $strategy, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $alias, string $field, $value, bool $caseSensitive)
+    protected function addWhereByStrategy(string $strategy, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $alias, string $field, $value, bool $caseSensitive, ClassMetadata $metadata = null)
     {
         // check if we have metadata
-        if (($metadata = func_get_arg(7)) instanceof ClassMetadata) {
+        if ($metadata instanceof ClassMetadata) {
             $type = $metadata->getTypeOfField($field);
         } else {
             @trigger_error('addWhereByStrategy() will require argument ClassMetadata in 3.0.', E_USER_DEPRECATED);