fix composite

Author: soyuka

src/Core/Bridge/Symfony/Bundle/Command/UpgradeApiResourceCommand.php

@@ -14,6 +14,7 @@
 namespace ApiPlatform\Core\Bridge\Symfony\Bundle\Command;
 
 use ApiPlatform\Core\Annotation\ApiResource;
+use ApiPlatform\Core\Api\IdentifiersExtractorInterface;
 use ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface;
 use ApiPlatform\Core\Operation\Factory\SubresourceOperationFactoryInterface;
 use ApiPlatform\Core\Upgrade\ColorConsoleDiffFormatter;
@@ -42,15 +43,17 @@ final class UpgradeApiResourceCommand extends Command
     private $subresourceOperationFactory;
     private $subresourceTransformer;
     private $reader;
+    private $identifiersExtractor;
     private $localCache = [];
 
-    public function __construct(ResourceNameCollectionFactoryInterface $resourceNameCollectionFactory, ResourceMetadataFactoryInterface $resourceMetadataFactory, SubresourceOperationFactoryInterface $subresourceOperationFactory, SubresourceTransformer $subresourceTransformer, AnnotationReader $reader)
+    public function __construct(ResourceNameCollectionFactoryInterface $resourceNameCollectionFactory, ResourceMetadataFactoryInterface $resourceMetadataFactory, SubresourceOperationFactoryInterface $subresourceOperationFactory, SubresourceTransformer $subresourceTransformer, AnnotationReader $reader, IdentifiersExtractorInterface $identifiersExtractor)
     {
         $this->resourceNameCollectionFactory = $resourceNameCollectionFactory;
         $this->resourceMetadataFactory = $resourceMetadataFactory;
         $this->subresourceOperationFactory = $subresourceOperationFactory;
         $this->subresourceTransformer = $subresourceTransformer;
         $this->reader = $reader;
+        $this->identifiersExtractor = $identifiersExtractor;
 
         parent::__construct();
     }
@@ -204,7 +207,7 @@ private function transformApiResource(InputInterface $input, OutputInterface $ou
                 continue;
             }
 
-            $traverser->addVisitor(new UpgradeApiResourceVisitor($attribute, $isAnnotation));
+            $traverser->addVisitor(new UpgradeApiResourceVisitor($attribute, $isAnnotation, $this->identifiersExtractor, $resourceClass));
 
             $oldCode = file_get_contents($fileName);
             $oldStmts = $parser->parse($oldCode);

src/Core/Upgrade/UpgradeApiResourceVisitor.php

@@ -16,13 +16,15 @@
 use ApiPlatform\Api\UrlGeneratorInterface;
 use ApiPlatform\Core\Annotation\ApiResource as LegacyApiResource;
 use ApiPlatform\Core\Annotation\ApiSubresource;
+use ApiPlatform\Core\Api\IdentifiersExtractorInterface;
 use ApiPlatform\Metadata\ApiResource;
 use ApiPlatform\Metadata\Delete;
 use ApiPlatform\Metadata\Get;
 use ApiPlatform\Metadata\GetCollection;
 use ApiPlatform\Metadata\GraphQl\Mutation;
 use ApiPlatform\Metadata\GraphQl\Query;
 use ApiPlatform\Metadata\GraphQl\QueryCollection;
+use ApiPlatform\Metadata\Link;
 use ApiPlatform\Metadata\Patch;
 use ApiPlatform\Metadata\Post;
 use ApiPlatform\Metadata\Put;
@@ -36,12 +38,16 @@ final class UpgradeApiResourceVisitor extends NodeVisitorAbstract
     use RemoveAnnotationTrait;
 
     private LegacyApiResource $resourceAnnotation;
+    private IdentifiersExtractorInterface $identifiersExtractor;
     private bool $isAnnotation = false;
+    private string $resourceClass;
 
-    public function __construct(LegacyApiResource $resourceAnnotation, bool $isAnnotation = false)
+    public function __construct(LegacyApiResource $resourceAnnotation, bool $isAnnotation, IdentifiersExtractorInterface $identifiersExtractor, string $resourceClass)
     {
         $this->resourceAnnotation = $resourceAnnotation;
         $this->isAnnotation = $isAnnotation;
+        $this->identifiersExtractor = $identifiersExtractor;
+        $this->resourceClass = $resourceClass;
     }
 
     /**
@@ -80,6 +86,10 @@ public function enterNode(Node $node)
                 $this->getGraphQlOperationsNamespaces($this->resourceAnnotation->graphql ?? [])
             ));
 
+            if (true === !($this->resourceAnnotation->attributes['composite_identifier'] ?? true)) {
+                $namespaces[] = Link::class;
+            }
+
             foreach ($node->stmts as $k => $stmt) {
                 if (!$stmt instanceof Node\Stmt\Use_) {
                     break;
@@ -202,6 +212,40 @@ public function enterNode(Node $node)
                     continue;
                 }
 
+                if ('compositeIdentifier' === $key) {
+                    if (false !== $value) {
+                        continue;
+                    }
+
+                    $identifiers = $this->identifiersExtractor->getIdentifiersFromResourceClass($this->resourceClass);
+                    $identifierNodeItems = [];
+                    foreach ($identifiers as $identifier) {
+                        $identifierNodes = [
+                            'compositeIdentifier' => new Node\Expr\ConstFetch(new Node\Name('false')),
+                            'fromClass' => new Node\Expr\ClassConstFetch(
+                                    new Node\Name(
+                                        'self'
+                                    ),
+                                    'class'
+                                ),
+                            'identifiers' => new Node\Expr\Array_(
+                                    [
+                                        new Node\Expr\ArrayItem(new Node\Scalar\String_($identifier)),
+                                    ],
+                                    ['kind' => Node\Expr\Array_::KIND_SHORT]
+                                ),
+                        ];
+
+                        $identifierNodeItems[] = new Node\Expr\ArrayItem(
+                            new Node\Expr\New_(new Node\Name('Link'), $this->arrayToArguments($identifierNodes)),
+                            new Node\Scalar\String_($identifier)
+                        );
+                    }
+
+                    $arguments['uriVariables'] = new Node\Expr\Array_($identifierNodeItems, ['kind' => Node\Expr\Array_::KIND_SHORT]);
+                    continue;
+                }
+
                 $arguments[$key] = $this->valueToNode($value);
             }
 

src/Symfony/Bundle/Resources/config/legacy/upgrade.xml

@@ -13,6 +13,7 @@
             <argument type="service" id="api_platform.subresource_operation_factory" />
             <argument type="service" id="api_platform.upgrade.subresource_transformer" />
             <argument type="service" id="annotations.reader" />
+            <argument type="service" id="api_platform.identifiers_extractor.legacy" />
         </service>
     </services>