Add test on #1449 query checker order by toMany

Author: abluchet

src/Bridge/Doctrine/Orm/Util/QueryChecker.php

@@ -146,17 +146,15 @@ public static function hasOrderByOnToManyJoin(QueryBuilder $queryBuilder, Manage
                 if (!isset($orderByAliases[$alias])) {
                     continue;
                 }
-
                 $relationship = QueryJoinParser::getJoinRelationship($join);
 
                 if (false !== strpos($relationship, '.')) {
                     /*
-                     * (Cannot select distinct identifiers from query with LIMIT and ORDER BY on a column from a fetch joined to-many association. Use output walkers)
-                     *
+                     * We select the parent alias because it may differ from the origin alias given above
                      * @see https://github.com/api-platform/core/issues/1313
                      */
-                    list($parentAlias, $association) = explode('.', $relationship);
-                    $metadata = QueryJoinParser::getClassMetadataFromJoinAlias($parentAlias, $queryBuilder, $managerRegistry);
+                    list($relationAlias, $association) = explode('.', $relationship);
+                    $metadata = QueryJoinParser::getClassMetadataFromJoinAlias($relationAlias, $queryBuilder, $managerRegistry);
                     if ($metadata->isCollectionValuedAssociation($association)) {
                         return true;
                     }

tests/Bridge/Doctrine/Orm/Util/QueryCheckerTest.php

@@ -176,4 +176,25 @@ public function testHasOrderByOnToManyJoinWithClassLeftJoin()
 
         $this->assertTrue(QueryChecker::hasOrderByOnToManyJoin($queryBuilder->reveal(), $managerRegistry->reveal()));
     }
+
+    /**
+     * Adds a test on the fix referenced in https://github.com/api-platform/core/pull/1449.
+     */
+    public function testOrderByOnToManyWithRelationAsBasis()
+    {
+        $queryBuilder = $this->prophesize(QueryBuilder::class);
+        $queryBuilder->getRootEntities()->willReturn(['Dummy']);
+        $queryBuilder->getRootAliases()->willReturn(['d']);
+        $queryBuilder->getDQLPart('join')->willReturn(['d' => [new Join('LEFT_JOIN', 'd.relatedDummy', 'a_1')]]);
+        $queryBuilder->getDQLPart('orderBy')->willReturn(['a_1.name' => new OrderBy('a_1.name', 'asc')]);
+        $classMetadata = $this->prophesize(ClassMetadata::class);
+        $classMetadata = $this->prophesize(ClassMetadata::class);
+        $classMetadata->isCollectionValuedAssociation('relatedDummy')->willReturn(true);
+        $objectManager = $this->prophesize(ObjectManager::class);
+        $objectManager->getClassMetadata('Dummy')->willReturn($classMetadata->reveal());
+        $managerRegistry = $this->prophesize(ManagerRegistry::class);
+        $managerRegistry->getManagerForClass('Dummy')->willReturn($objectManager->reveal());
+
+        $this->assertTrue(QueryChecker::hasOrderByOnToManyJoin($queryBuilder->reveal(), $managerRegistry->reveal()));
+    }
 }

tests/Bridge/Doctrine/Orm/Util/QueryJoinParserTest.php

@@ -33,7 +33,7 @@ public function testGetClassMetadataFromJoinAlias()
         $queryBuilder = $this->prophesize(QueryBuilder::class);
         $queryBuilder->getRootEntities()->willReturn(['Dummy']);
         $queryBuilder->getRootAliases()->willReturn(['d']);
-        $queryBuilder->getDQLPart('join')->willReturn(['a_1' => new Join('INNER_JOIN', 'relatedDummy', 'a_1', null, 'a_1.name = r.name')]);
+        $queryBuilder->getDQLPart('join')->willReturn(['a_1' => [new Join('INNER_JOIN', 'relatedDummy', 'a_1', null, 'a_1.name = r.name')]]);
         $classMetadata = $this->prophesize(ClassMetadata::class);
         $objectManager = $this->prophesize(ObjectManager::class);
         $objectManager->getClassMetadata('Dummy')->willReturn($classMetadata->reveal());