IterableType implements the BC in the LeafType interface

Author: alanpoulain

src/GraphQl/Type/Definition/IterableType.php

@@ -14,7 +14,6 @@
 namespace ApiPlatform\Core\GraphQl\Type\Definition;
 
 use GraphQL\Error\Error;
-use GraphQL\Error\InvariantViolation;
 use GraphQL\Language\AST\BooleanValueNode;
 use GraphQL\Language\AST\FloatValueNode;
 use GraphQL\Language\AST\IntValueNode;
@@ -44,7 +43,7 @@ public function serialize($value)
     {
         // is_iterable
         if (!(\is_array($value) || $value instanceof \Traversable)) {
-            throw new InvariantViolation(sprintf('Iterable cannot represent non iterable value: %s', Utils::printSafe($value)));
+            throw new Error(sprintf('Iterable cannot represent non iterable value: %s', Utils::printSafe($value)));
         }
 
         return $value;
@@ -66,13 +65,14 @@ public function parseValue($value)
     /**
      * {@inheritdoc}
      */
-    public function parseLiteral($valueNode)
+    public function parseLiteral($valueNode, array $variables = null)
     {
         if ($valueNode instanceof ObjectValueNode || $valueNode instanceof ListValueNode) {
             return $this->parseIterableLiteral($valueNode);
         }
 
-        return null;
+        // Intentionally without message, as all information already in wrapped Exception
+        throw new \Exception();
     }
 
     /**

tests/GraphQl/Type/Definition/IterableTypeTest.php

@@ -15,7 +15,6 @@
 
 use ApiPlatform\Core\GraphQl\Type\Definition\IterableType;
 use GraphQL\Error\Error;
-use GraphQL\Error\InvariantViolation;
 use GraphQL\Language\AST\BooleanValueNode;
 use GraphQL\Language\AST\FloatValueNode;
 use GraphQL\Language\AST\IntValueNode;
@@ -36,8 +35,8 @@ public function testSerialize()
     {
         $iterableType = new IterableType();
 
-        $this->expectException(InvariantViolation::class);
-        $this->expectExceptionMessage('Iterable cannot represent non iterable value: "foo"');
+        $this->expectException(Error::class);
+        $this->expectExceptionMessage('Iterable cannot represent non iterable value: foo');
 
         $iterableType->serialize('foo');
 
@@ -60,7 +59,8 @@ public function testParseLiteral()
     {
         $iterableType = new IterableType();
 
-        $this->assertNull($iterableType->parseLiteral(new IntValueNode(['value' => 1])));
+        $this->expectException(\Exception::class);
+        $iterableType->parseLiteral(new IntValueNode(['value' => 1]));
 
         $listValueNode = new ListValueNode(['values' => []]);
         $this->assertEquals([], $iterableType->parseLiteral($listValueNode));