fix(symfony): unload deprecated json problem services

Author: soyuka

src/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php

@@ -588,6 +588,10 @@ private function registerJsonProblemConfiguration(array $errorFormats, XmlFileLo
             return;
         }
 
+        if ($config['defaults']['extra_properties']['rfc_7807_compliant_errors'] ?? false) {
+            $loader->load('legacy/problem.xml');
+        }
+
         $loader->load('problem.xml');
     }
 

src/Symfony/Bundle/Resources/config/legacy/problem.xml

@@ -0,0 +1,24 @@
+<?xml version="1.0" ?>
+
+<container xmlns="http://symfony.com/schema/dic/services"
+           xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+           xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
+
+    <services>
+        <service id="api_platform.problem.normalizer.constraint_violation_list" class="ApiPlatform\Problem\Serializer\ConstraintViolationListNormalizer" public="false">
+            <argument>%api_platform.validator.serialize_payload_fields%</argument>
+            <argument type="service" id="api_platform.name_converter" on-invalid="ignore" />
+
+            <tag name="serializer.normalizer" priority="-780" />
+        </service>
+
+        <!-- deprecated -->
+        <service id="api_platform.problem.normalizer.error" class="ApiPlatform\Problem\Serializer\ErrorNormalizer" public="false">
+            <argument>%kernel.debug%</argument>
+            <argument type="collection"></argument>
+
+            <tag name="serializer.normalizer" priority="-810" />
+        </service>
+    </services>
+
+</container>

src/Symfony/Bundle/Resources/config/problem.xml

@@ -12,27 +12,12 @@
             <tag name="serializer.encoder" />
         </service>
 
-        <service id="api_platform.problem.normalizer.constraint_violation_list" class="ApiPlatform\Problem\Serializer\ConstraintViolationListNormalizer" public="false">
-            <argument>%api_platform.validator.serialize_payload_fields%</argument>
-            <argument type="service" id="api_platform.name_converter" on-invalid="ignore" />
-
-            <tag name="serializer.normalizer" priority="-780" />
-        </service>
-
         <service id="api_platform.problem.normalizer.validation_exception" class="ApiPlatform\Symfony\Validator\Serializer\ValidationExceptionNormalizer" public="false">
             <argument type="service" id="api_platform.serializer.normalizer.item" />
             <argument type="service" id="api_platform.name_converter" on-invalid="ignore" />
 
             <tag name="serializer.normalizer" priority="-800" />
         </service>
-
-        <!-- deprecated -->
-        <service id="api_platform.problem.normalizer.error" class="ApiPlatform\Problem\Serializer\ErrorNormalizer" public="false">
-            <argument>%kernel.debug%</argument>
-            <argument type="collection"></argument>
-
-            <tag name="serializer.normalizer" priority="-810" />
-        </service>
     </services>
 
 </container>

tests/Fixtures/app/AppKernel.php

@@ -245,6 +245,10 @@ class_exists(NativePasswordHasher::class) ? 'password_hashers' : 'encoders' => [
             $legacyConfig = ['event_listeners_backward_compatibility_layer' => $metadataBackwardCompatibilityLayer];
         }
 
+        if (!$rfc7807CompliantErrors) {
+            $loader->load(__DIR__."/config/config_legacy_error.yml");
+        }
+
         $c->prependExtensionConfig('api_platform', $legacyConfig + [
             'mapping' => [
                 'paths' => ['%kernel.project_dir%/../TestBundle/Resources/config/api_resources'],

tests/Fixtures/app/config/config_common.yml

@@ -433,10 +433,6 @@ services:
         arguments:
             $decorated: '@.inner'
 
-    ApiPlatform\Tests\Fixtures\TestBundle\Serializer\ErrorNormalizer:
-        decorates: 'api_platform.problem.normalizer.error'
-        arguments: [ '@.inner' ]
-
     api_platform.http_cache.tag_collector:
         class: ApiPlatform\Tests\Fixtures\TestBundle\HttpCache\TagCollectorDefault
         public: true

tests/Fixtures/app/config/config_legacy_error.yml

@@ -0,0 +1,5 @@
+services:
+    ApiPlatform\Tests\Fixtures\TestBundle\Serializer\ErrorNormalizer:
+        decorates: 'api_platform.problem.normalizer.error'
+        arguments: [ '@.inner' ]
+