moved content negotiation to before firewall

Author: Joe Bennett

features/filter/filter_validation.feature

@@ -1,5 +1,8 @@
 Feature: Validate filters based upon filter description
 
+  Background:
+    Given I add "Accept" header equal to "application/json"
+
   @createSchema
   Scenario: Required filter should not throw an error if set
     When I am on "/filter_validators?required=foo&required-allow-empty=&arrayRequired[foo]="
@@ -13,7 +16,7 @@ Feature: Validate filters based upon filter description
   Scenario: Required filter should throw an error if not set
     When I am on "/filter_validators"
     Then the response status code should be 400
-    Then the JSON node "detail" should match '/^Query parameter "required" is required\nQuery parameter "required-allow-empty" is required$/'
+    And the JSON node "detail" should match '/^Query parameter "required" is required\nQuery parameter "required-allow-empty" is required$/'
 
   Scenario: Required filter should not throw an error if set
     When I am on "/array_filter_validators?arrayRequired[]=foo&indexedArrayRequired[foo]=foo"

src/Bridge/Symfony/Bundle/Resources/config/api.xml

@@ -150,15 +150,15 @@
 
         <!-- Event listeners -->
 
-        <!-- kernel.request priority must be < 8 to be executed after the Firewall -->
         <service id="api_platform.listener.request.add_format" class="ApiPlatform\Core\EventListener\AddFormatListener">
             <argument type="service" id="api_platform.negotiator" />
             <argument type="service" id="api_platform.metadata.resource.metadata_factory" />
             <argument>%api_platform.formats%</argument>
 
-            <tag name="kernel.event_listener" event="kernel.request" method="onKernelRequest" priority="7" />
+            <tag name="kernel.event_listener" event="kernel.request" method="onKernelRequest" priority="28" />
         </service>
 
+        <!-- kernel.request priority must be < 8 to be executed after the Firewall -->
         <service id="api_platform.listener.request.read" class="ApiPlatform\Core\EventListener\ReadListener">
             <argument type="service" id="api_platform.collection_data_provider" />
             <argument type="service" id="api_platform.item_data_provider" />

src/EventListener/AddFormatListener.php

@@ -65,11 +65,11 @@ public function __construct(Negotiator $negotiator, $resourceMetadataFactory, ar
     public function onKernelRequest(RequestEvent $event): void
     {
         $request = $event->getRequest();
-        if (
-                !($request->attributes->has('_api_resource_class')
-                || $request->attributes->getBoolean('_api_respond', false)
-                || $request->attributes->getBoolean('_graphql', false))
-        ) {
+        if (!(
+            $request->attributes->has('_api_resource_class')
+            || $request->attributes->getBoolean('_api_respond', false)
+            || $request->attributes->getBoolean('_graphql', false)
+        )) {
             return;
         }