Put mutation for an item

Author: alanpoulain

features/graphql/mutation.feature

@@ -50,7 +50,6 @@ Feature: GraphQL mutation support
     And the header "Content-Type" should be equal to "application/json"
     And the JSON node "data.deleteDummy.id" should be equal to 1
 
-  @dropSchema
   Scenario: Delete an item with composite identifiers through a mutation
     Given there are Composite identifier objects
     When I send the following GraphQL request:
@@ -71,3 +70,47 @@ Feature: GraphQL mutation support
     And the header "Content-Type" should be equal to "application/json"
     And the JSON node "data.deleteCompositeRelation.compositeItem.id" should be equal to 1
     And the JSON node "data.deleteCompositeRelation.compositeLabel.id" should be equal to 1
+
+  Scenario: Modify an item through a mutation
+    Given there is 1 dummy objects
+    When I send the following GraphQL request:
+    """
+    mutation {
+      putDummy(input: {id: 1, description: "Modified description."}) {
+        id,
+        name,
+        description
+      }
+    }
+    """
+    Then the response status code should be 200
+    And the response should be in JSON
+    And the header "Content-Type" should be equal to "application/json"
+    And the JSON node "data.putDummy.id" should be equal to 1
+    And the JSON node "data.putDummy.name" should be equal to "Dummy #1"
+    And the JSON node "data.putDummy.description" should be equal to "Modified description."
+
+  @dropSchema
+  # @TODO Find a way to manage composite identifiers.
+  Scenario: Modify an item with composite identifiers through a mutation
+    Given there are Composite identifier objects
+    When I send the following GraphQL request:
+    """
+    mutation {
+      putCompositeRelation(input: {compositeItem: {id: 1}, compositeLabel: {id: 1}, value: "Modified value."}) {
+        compositeItem {
+          id
+        },
+        compositeLabel {
+          id
+        },
+        value
+      }
+    }
+    """
+    #Then the response status code should be 200
+    #And the response should be in JSON
+    #And the header "Content-Type" should be equal to "application/json"
+    #And the JSON node "data.putCompositeRelation.compositeItem.id" should be equal to 1
+    #And the JSON node "data.putCompositeRelation.compositeLabel.id" should be equal to 1
+    #And the JSON node "data.putCompositeRelation.value" should be equal to "Modified value."

src/Bridge/Graphql/Resolver/ItemMutationResolverFactory.php

@@ -16,8 +16,10 @@
 use ApiPlatform\Core\Api\IdentifiersExtractorInterface;
 use ApiPlatform\Core\DataPersister\DataPersisterInterface;
 use ApiPlatform\Core\DataProvider\ItemDataProviderInterface;
+use ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface;
 use GraphQL\Error\Error;
 use GraphQL\Type\Definition\ResolveInfo;
+use Symfony\Component\Serializer\Serializer;
 
 /**
  * Creates a function resolving a GraphQL mutation of an item.
@@ -30,12 +32,16 @@ final class ItemMutationResolverFactory implements ItemMutationResolverFactoryIn
 {
     private $identifiersExtractor;
     private $itemDataProvider;
+    private $serializer;
+    private $resourceMetadataFactory;
     private $dataPersister;
 
-    public function __construct(IdentifiersExtractorInterface $identifiersExtractor, ItemDataProviderInterface $itemDataProvider, DataPersisterInterface $dataPersister)
+    public function __construct(IdentifiersExtractorInterface $identifiersExtractor, ItemDataProviderInterface $itemDataProvider, Serializer $serializer, ResourceMetadataFactoryInterface $resourceMetadataFactory, DataPersisterInterface $dataPersister)
     {
         $this->identifiersExtractor = $identifiersExtractor;
         $this->itemDataProvider = $itemDataProvider;
+        $this->serializer = $serializer;
+        $this->resourceMetadataFactory = $resourceMetadataFactory;
         $this->dataPersister = $dataPersister;
     }
 
@@ -59,17 +65,30 @@ public function createItemMutationResolver(string $resourceClass, string $operat
             } else {
                 $id = $args['input'][$identifiers[0]];
             }
-            $item = $this->itemDataProvider->getItem($resourceClass, $id);
-
-            if (null === $item) {
-                throw Error::createLocatedError("Item $resourceClass $id not found", $info->fieldNodes, $info->path);
-            }
 
             if ('delete' === $operationName) {
+                $item = $this->itemDataProvider->getItem($resourceClass, $id);
+
+                if (null === $item) {
+                    throw Error::createLocatedError("Item $resourceClass $id not found", $info->fieldNodes, $info->path);
+                }
+
                 $this->dataPersister->remove($item);
-            }
 
-            return $args['input'];
+                return $args['input'];
+            } elseif ('put' === $operationName) {
+                $item = $this->serializer->denormalize($args['input'], $resourceClass, null, ['resource_class' => $resourceClass]);
+
+                $this->dataPersister->persist($item);
+
+                return $this->serializer->normalize(
+                    $item,
+                    null,
+                    ['graphql' => true] + $this->resourceMetadataFactory
+                        ->create($resourceClass)
+                        ->getItemOperationAttribute($operationName, 'normalization_context', [], true)
+                );
+            }
         };
     }
 }

src/Bridge/Graphql/Type/SchemaBuilder.php

@@ -259,7 +259,7 @@ private function convertType(Type $type, string $operationName, bool $isInput =
             return $this->paginationEnabled ? $this->getResourcePaginatedCollectionType($graphqlType, $isInput) : GraphQLType::listOf($graphqlType);
         }
 
-        return $type->isNullable() ? $graphqlType : GraphQLType::nonNull($graphqlType);
+        return $type->isNullable() || ($isMutation && 'put' === $operationName) ? $graphqlType : GraphQLType::nonNull($graphqlType);
     }
 
     /**

src/Bridge/Symfony/Bundle/Resources/config/graphql.xml

@@ -28,6 +28,8 @@
         <service id="api_platform.graphql.item_mutation_resolver_factory" class="ApiPlatform\Core\Bridge\Graphql\Resolver\ItemMutationResolverFactory" public="false">
             <argument type="service" id="api_platform.identifiers_extractor.cached" />
             <argument type="service" id="api_platform.item_data_provider" />
+            <argument type="service" id="serializer" />
+            <argument type="service" id="api_platform.metadata.resource.metadata_factory" />
             <argument type="service" id="api_platform.data_persister" />
         </service>
 

tests/Bridge/Graphql/Resolver/ItemMutationResolverFactoryTest.php

@@ -17,10 +17,12 @@
 use ApiPlatform\Core\Bridge\Graphql\Resolver\ItemMutationResolverFactory;
 use ApiPlatform\Core\DataPersister\DataPersisterInterface;
 use ApiPlatform\Core\DataProvider\ItemDataProviderInterface;
+use ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface;
 use GraphQL\Type\Definition\ResolveInfo;
 use PHPUnit\Framework\TestCase;
 use Prophecy\Argument;
 use Prophecy\Prophecy\ObjectProphecy;
+use Symfony\Component\Serializer\Serializer;
 
 /**
  * @author Alan Poulain <[email protected]>
@@ -107,9 +109,15 @@ private function mockItemMutationResolverFactory($item, array $identifiers, $fla
         $itemDataProviderProphecy = $this->prophesize(ItemDataProviderInterface::class);
         $itemDataProviderProphecy->getItem('resourceClass', $flatId)->willReturn($item);
 
+        $serializerProphecy = $this->prophesize(Serializer::class);
+
+        $resourceMetadataFactoryProphecy = $this->prophesize(ResourceMetadataFactoryInterface::class);
+
         return new ItemMutationResolverFactory(
             $identifiersExtractorProphecy->reveal(),
             $itemDataProviderProphecy->reveal(),
+            $serializerProphecy->reveal(),
+            $resourceMetadataFactoryProphecy->reveal(),
             $dataPersisterProphecy->reveal()
         );
     }