Add new parameter enable_entrypoint to Symony bundle #1568

Author: Alexis Thinardon

src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php

@@ -141,6 +141,7 @@ public function load(array $configs, ContainerBuilder $container)
      */
     private function handleConfig(ContainerBuilder $container, array $config, array $formats, array $errorFormats)
     {
+        $container->setParameter('api_platform.enable_entrypoint', $config['enable_entrypoint']);
         $container->setParameter('api_platform.title', $config['title']);
         $container->setParameter('api_platform.description', $config['description']);
         $container->setParameter('api_platform.version', $config['version']);

src/Bridge/Symfony/Bundle/DependencyInjection/Configuration.php

@@ -87,6 +87,7 @@ public function getConfigTreeBuilder()
                 ->end()
                 ->booleanNode('enable_swagger')->defaultValue(true)->info('Enable the Swagger documentation and export.')->end()
                 ->booleanNode('enable_swagger_ui')->defaultValue(class_exists(TwigBundle::class))->info('Enable Swagger ui.')->end()
+                ->booleanNode('enable_entrypoint')->defaultTrue()->info('Enable/disable the entry-point')->end()
 
                 ->arrayNode('oauth')
                     ->canBeEnabled()

src/Bridge/Symfony/Bundle/Resources/config/routing/api.xml

@@ -13,10 +13,4 @@
         <requirement key="index">index</requirement>
     </route>
 
-    <route id="api_doc" path="/docs.{_format}">
-        <default key="_controller">api_platform.action.documentation</default>
-        <default key="_api_respond">1</default>
-        <default key="_format" />
-    </route>
-
 </routes>

src/Bridge/Symfony/Bundle/Resources/config/routing/doc.xml

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+
+<routes xmlns="http://symfony.com/schema/routing"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:schemaLocation="http://symfony.com/schema/routing
+        http://symfony.com/schema/routing/routing-1.0.xsd">
+
+    <route id="api_doc" path="/docs.{_format}">
+        <default key="_controller">api_platform.action.documentation</default>
+        <default key="_api_respond">1</default>
+        <default key="_format" />
+    </route>
+
+</routes>

src/Bridge/Symfony/Routing/ApiLoader.php

@@ -146,6 +146,10 @@ private function loadExternalFiles(RouteCollection $routeCollection)
     {
         $routeCollection->addCollection($this->fileLoader->load('api.xml'));
 
+        if ($this->container->getParameter('api_platform.enable_entrypoint')) {
+            $routeCollection->addCollection($this->fileLoader->load('doc.xml'));
+        }
+
         if ($this->graphqlEnabled) {
             $graphqlCollection = $this->fileLoader->load('graphql.xml');
             $graphqlCollection->addDefaults(['_graphql' => true]);

tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php

@@ -390,6 +390,7 @@ private function getPartialContainerBuilderProphecy($test = false)
             'api_platform.http_cache.shared_max_age' => null,
             'api_platform.http_cache.vary' => ['Accept'],
             'api_platform.http_cache.public' => null,
+            'api_platform.enable_entrypoint' => true,
         ];
 
         foreach ($parameters as $key => $value) {

tests/Bridge/Symfony/Bundle/DependencyInjection/ConfigurationTest.php

@@ -78,6 +78,7 @@ public function testDefaultConfig()
             'enable_nelmio_api_doc' => false,
             'enable_swagger' => true,
             'enable_swagger_ui' => true,
+            'enable_entrypoint' => true,
             'graphql' => [
                 'enabled' => true,
                 'graphiql' => [

tests/Bridge/Symfony/Routing/ApiLoaderTest.php

@@ -210,6 +210,7 @@ private function getApiLoaderWithResourceMetadata(ResourceMetadata $resourceMeta
             $containerProphecy->has($possibleArgument)->willReturn(true);
         }
         $containerProphecy->getParameter('api_platform.enable_swagger')->willReturn(true);
+        $containerProphecy->getParameter('api_platform.enable_entrypoint')->willReturn(true);
 
         $containerProphecy->has(Argument::type('string'))->willReturn(false);