Merge pull request #3231 from soyuka/patch/readable-names

More Descriptive Input/Output class names

Author: dunglas

src/JsonSchema/SchemaFactory.php

@@ -206,7 +206,9 @@ private function buildDefinitionName(string $resourceClass, string $format = 'js
 
         $prefix = $resourceMetadata->getShortName();
         if (null !== $inputOrOutputClass && $resourceClass !== $inputOrOutputClass) {
-            $prefix .= ':'.md5($inputOrOutputClass);
+            $parts = explode('\\', $inputOrOutputClass);
+            $shortName = end($parts);
+            $prefix .= ':'.$shortName;
         }
 
         if (isset($this->distinctFormats[$format])) {

tests/Swagger/Serializer/DocumentationNormalizerV2Test.php

@@ -2780,7 +2780,7 @@ private function doTestNormalizeWithInputAndOutputClass(): void
                                 'schema' => [
                                     'type' => 'array',
                                     'items' => [
-                                        '$ref' => '#/definitions/Dummy:300dcd476cef011532fb0ca7683395d7',
+                                        '$ref' => '#/definitions/Dummy:OutputDto',
                                     ],
                                 ],
                             ],
@@ -2805,7 +2805,7 @@ private function doTestNormalizeWithInputAndOutputClass(): void
                             201 => [
                                 'description' => 'Dummy resource created',
                                 'schema' => [
-                                    '$ref' => '#/definitions/Dummy:300dcd476cef011532fb0ca7683395d7',
+                                    '$ref' => '#/definitions/Dummy:OutputDto',
                                 ],
                             ],
                             400 => [
@@ -2821,7 +2821,7 @@ private function doTestNormalizeWithInputAndOutputClass(): void
                                 'in' => 'body',
                                 'description' => 'The new Dummy resource',
                                 'schema' => [
-                                    '$ref' => '#/definitions/Dummy:b4f76c1a44965bd401aa23bb37618acc',
+                                    '$ref' => '#/definitions/Dummy:InputDto',
                                 ],
                             ],
                         ],
@@ -2845,7 +2845,7 @@ private function doTestNormalizeWithInputAndOutputClass(): void
                             200 => [
                                 'description' => 'Dummy resource response',
                                 'schema' => [
-                                    '$ref' => '#/definitions/Dummy:300dcd476cef011532fb0ca7683395d7',
+                                    '$ref' => '#/definitions/Dummy:OutputDto',
                                 ],
                             ],
                             404 => [
@@ -2871,15 +2871,15 @@ private function doTestNormalizeWithInputAndOutputClass(): void
                                 'in' => 'body',
                                 'description' => 'The updated Dummy resource',
                                 'schema' => [
-                                    '$ref' => '#/definitions/Dummy:b4f76c1a44965bd401aa23bb37618acc',
+                                    '$ref' => '#/definitions/Dummy:InputDto',
                                 ],
                             ],
                         ],
                         'responses' => [
                             200 => [
                                 'description' => 'Dummy resource updated',
                                 'schema' => [
-                                    '$ref' => '#/definitions/Dummy:300dcd476cef011532fb0ca7683395d7',
+                                    '$ref' => '#/definitions/Dummy:OutputDto',
                                 ],
                             ],
                             400 => [
@@ -2893,7 +2893,7 @@ private function doTestNormalizeWithInputAndOutputClass(): void
                 ],
             ]),
             'definitions' => new \ArrayObject([
-                'Dummy:300dcd476cef011532fb0ca7683395d7' => new \ArrayObject([
+                'Dummy:OutputDto' => new \ArrayObject([
                     'type' => 'object',
                     'description' => 'This is a dummy.',
                     'externalDocs' => [
@@ -2911,7 +2911,7 @@ private function doTestNormalizeWithInputAndOutputClass(): void
                         ]),
                     ],
                 ]),
-                'Dummy:b4f76c1a44965bd401aa23bb37618acc' => new \ArrayObject([
+                'Dummy:InputDto' => new \ArrayObject([
                     'type' => 'object',
                     'description' => 'This is a dummy.',
                     'externalDocs' => [