fix error when disabling eager_loading. Introduced by d3b690e

Author: jdeniau

src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php

@@ -412,8 +412,10 @@ private function registerDoctrineExtensionConfiguration(ContainerBuilder $contai
             return;
         }
 
-        $container->removeDefinition('api_platform.doctrine.orm.query_extension.eager_loading');
-        $container->removeDefinition('api_platform.doctrine.orm.query_extension.filter_eager_loading');
+        $container->removeAlias('api_platform.doctrine.orm.query_extension.eager_loading');
+        $container->removeAlias('api_platform.doctrine.orm.query_extension.filter_eager_loading');
+        $container->removeDefinition('ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\EagerLoadingExtension');
+        $container->removeDefinition('ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\FilterEagerLoadingExtension');
     }
 
     private function registerHttpCache(ContainerBuilder $container, array $config, XmlFileLoader $loader, bool $useDoctrine)

tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php

@@ -275,8 +275,10 @@ public function testDisableEagerLoadingExtension()
     {
         $containerBuilderProphecy = $this->getBaseContainerBuilderProphecy();
         $containerBuilderProphecy->setParameter('api_platform.eager_loading.enabled', false)->shouldBeCalled();
-        $containerBuilderProphecy->removeDefinition('api_platform.doctrine.orm.query_extension.eager_loading')->shouldBeCalled();
-        $containerBuilderProphecy->removeDefinition('api_platform.doctrine.orm.query_extension.filter_eager_loading')->shouldBeCalled();
+        $containerBuilderProphecy->removeDefinition('ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\EagerLoadingExtension')->shouldBeCalled();
+        $containerBuilderProphecy->removeDefinition('ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\FilterEagerLoadingExtension')->shouldBeCalled();
+        $containerBuilderProphecy->removeAlias('api_platform.doctrine.orm.query_extension.eager_loading')->shouldBeCalled();
+        $containerBuilderProphecy->removeAlias('api_platform.doctrine.orm.query_extension.filter_eager_loading')->shouldBeCalled();
         $containerBuilder = $containerBuilderProphecy->reveal();
         $this->extension->load(array_merge_recursive(self::DEFAULT_CONFIG, ['api_platform' => ['eager_loading' => ['enabled' => false]]]), $containerBuilder);
     }