Merge pull request #2685 from soyuka/fix-attributes-override-2

Metadata: Attributes default value should be null not an empty array

Author: soyuka

src/Metadata/Resource/Factory/AnnotationResourceMetadataFactory.php

@@ -85,7 +85,7 @@ private function createMetadata(ApiResource $annotation, ResourceMetadata $paren
                 $annotation->iri,
                 $annotation->itemOperations,
                 $annotation->collectionOperations,
-                $annotation->attributes,
+                $annotation->attributes ?: null,
                 $annotation->subresourceOperations,
                 $annotation->graphql
             );

tests/Metadata/Resource/Factory/AnnotationResourceMetadataFactoryTest.php

@@ -46,6 +46,17 @@ public function testCreate($reader, $decorated, string $expectedShortName, strin
         $this->assertEquals(['foo' => 'bar'], $metadata->getGraphql());
     }
 
+    public function testCreateWithoutAttributes()
+    {
+        $annotation = new ApiResource([]);
+        $reader = $this->prophesize(Reader::class);
+        $reader->getClassAnnotation(Argument::type(\ReflectionClass::class), ApiResource::class)->willReturn($annotation)->shouldBeCalled();
+        $factory = new AnnotationResourceMetadataFactory($reader->reveal(), null);
+        $metadata = $factory->create(Dummy::class);
+
+        $this->assertNull($metadata->getAttributes());
+    }
+
     public function getCreateDependencies()
     {
         $annotation = new ApiResource([